Skip to content

[salesforce] Implement login_stream data stream for Salesforce #4941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 28, 2023

Conversation

kush-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Generated the skeleton of Salesforce integration package.
  • Added 1 data stream ( login_stream )
  • Added data collection logic.
  • Added the ingest pipelines.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
  • Added system test cases.
  • Added two new visualization in the Login dashboard as part of login_stream data stream
  1. Top 10 Postal code by user count [Logs Salesforce]
  2. Top 10 Application type by user count [Logs Salesforce]

NOTE: The Dashboard is currently exported in 8.7.0-SNAPSHOT for review purpose only, it should be updated to 8.7.0 before merging this PR, so don't merge this PR unless updated to8.7.0

login

Related issues

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^8.7.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/salesforce directory.
  • Run the following command to run tests.

elastic-package test

@kush-elastic kush-elastic added enhancement New feature or request Team:Service-Integrations Label for the Observability Service Integrations team Integration:salesforce Salesforce labels Jan 5, 2023
@kush-elastic kush-elastic requested a review from a team as a code owner January 5, 2023 13:58
@kush-elastic kush-elastic self-assigned this Jan 5, 2023
@elasticmachine
Copy link

elasticmachine commented Jan 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-25T08:15:19.820+0000

  • Duration: 17 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jan 5, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 12.5
Classes 100.0% (5/5) 💚 12.5
Methods 98.387% (61/62) 👍 14.871
Lines 96.293% (1247/1295) 👍 3.49
Conditionals 100.0% (0/0) 💚

@harnish-crest-data
Copy link
Contributor

LGTM! Approved.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic
Copy link

botelastic bot commented Feb 23, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Feb 23, 2023
@botelastic
Copy link

botelastic bot commented Mar 25, 2023

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Mar 25, 2023
@kush-elastic kush-elastic reopened this Apr 12, 2023
@botelastic botelastic bot removed the Stalled label Apr 12, 2023
@kush-elastic kush-elastic requested a review from a team April 25, 2023 08:00
@kush-elastic kush-elastic requested review from a team as code owners April 25, 2023 08:00
@kush-elastic kush-elastic force-pushed the package_salesforce_login_stream branch from afba4b1 to 613727f Compare April 25, 2023 08:04
@florianl florianl removed the request for review from a team April 25, 2023 08:08
@kush-elastic
Copy link
Contributor Author

@agithomas, we have resolved merge conflicts. Should we merge this PR?

@kush-elastic kush-elastic merged commit d64ef24 into elastic:main Apr 28, 2023
@elasticmachine
Copy link

Package salesforce - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=salesforce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:salesforce Salesforce Team:Service-Integrations Label for the Observability Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants