Skip to content

Improve Custom Logs documentation #5153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 31, 2023
Merged

Conversation

rdner
Copy link
Member

@rdner rdner commented Jan 31, 2023

What does this PR do?

Now it describes detailed steps how to set it up.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
    - [ ] I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshot 2023-01-31 at 17 10 29

Now it describes detailed steps how to set it up.
@rdner rdner added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] labels Jan 31, 2023
@rdner rdner requested a review from a team as a code owner January 31, 2023 15:06
@rdner rdner self-assigned this Jan 31, 2023
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@rdner rdner requested review from jlind23 and removed request for fearful-symmetry and leehinman January 31, 2023 15:08
@elasticmachine
Copy link

elasticmachine commented Jan 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-31T16:40:29.896+0000

  • Duration: 13 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 33.333% (1/3) 👎 -54.74
Lines 100.0% (0/0) 💚 8.02
Conditionals 100.0% (0/0) 💚

@rdner rdner requested a review from belimawr January 31, 2023 16:44
@jlind23 jlind23 requested a review from felix-lessoer January 31, 2023 17:06
@rdner rdner merged commit 49b00c9 into elastic:main Jan 31, 2023
@rdner rdner deleted the improve-log-docs branch January 31, 2023 17:16
@elasticmachine
Copy link

Package log - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants