Skip to content

System dashboards add filters #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 8, 2023
Merged

System dashboards add filters #5198

merged 5 commits into from
Feb 8, 2023

Conversation

pchila
Copy link
Member

@pchila pchila commented Feb 7, 2023 •
edited
Loading

What does this PR do?

Added dataset filters for system metrics dashboards

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@pchila pchila added the bug Something isn't working, use only for issues label Feb 7, 2023
@pchila pchila requested review from a team as code owners February 7, 2023 09:59
@elasticmachine
Copy link

elasticmachine commented Feb 7, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-08T07:31:07.185+0000

  • Duration: 15 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 0
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 7, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 60.759% (48/79) 👎 -33.58
Lines 99.533% (2771/2784) 👍 34.205
Conditionals 100.0% (0/0) 💚

jlind23
jlind23 reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @leehinman @fearful-symmetry can I have 👀 on this?

@jlind23 jlind23 requested a review from leehinman February 7, 2023 16:35
leehinman
leehinman reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just one question on a query for docker-fleet-agent.

packages/system/kibana/dashboard/system-79ffd6e0-faa0-11e6-947f-177f697178b8.json Outdated
@@ -8,7 +8,7 @@
"highlightAll": true,
"query": {
"language": "kuery",
"query": ""
"query": "host.name:\"docker-fleet-agent\""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this query for? I don't remember the system dashboard having a query for docker-fleet-agent specifically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, there should not be a filter like that... I probably slipped up while modifying the dashboards... I will check it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a fixup without that filter.. I didn't realize that would be added when navigating from the system overview to the host overview by clicking on a hostname so when I modified the dashboard that got saved and exported as well 😅

Nice catch! 👍

@pchila pchila merged commit e04947d into elastic:main Feb 8, 2023
@elasticmachine
Copy link

Package system - 1.24.1 containing this change is available at https://epr.elastic.co/search?package=system

@pchila pchila deleted the system-dashboards-add-filters branch February 7, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman left review comments

@jlind23 jlind23 jlind23 approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry was automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec was automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[System] Dashboards do not prefilter on dataset values
4 participants
@pchila @elasticmachine @jlind23 @leehinman