Skip to content

[Logstash] Add datastream period option #5202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 10, 2023

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Feb 7, 2023

What does this PR do?

  • Add the period variable to each metrics data stream to enable granular polling frequency
  • Release the package to a GA version and set the metrics data streams as beta

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Build Logstash package
  • elastic-package stack up -v -d
  • Install Logstash package

Related issues

Screenshots

image

@crespocarlos crespocarlos changed the title Add datastream period option [Logstash] Add datastream period option Feb 7, 2023
@elasticmachine
Copy link

elasticmachine commented Feb 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-08T09:24:50.422+0000

  • Duration: 18 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 100.0% (46/46) 💚 39.241
Lines 87.558% (190/217) 👎 -11.975
Conditionals 100.0% (0/0) 💚

@crespocarlos crespocarlos added Integration:logstash Logstash Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services labels Feb 8, 2023
@crespocarlos crespocarlos marked this pull request as ready for review February 9, 2023 14:49
@crespocarlos crespocarlos requested a review from a team as a code owner February 9, 2023 14:49
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crespocarlos crespocarlos merged commit 20e4361 into elastic:main Feb 10, 2023
@elasticmachine
Copy link

Package logstash - 2.2.1-preview1 containing this change is available at https://epr.elastic.co/search?package=logstash

bhapas pushed a commit to bhapas/integrations that referenced this pull request Feb 16, 2023
* Add datastream period option

* Update changelog

* Revert release:beta changes

* Fix changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:logstash Logstash Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants