Skip to content

[Azure Logs] Add storage_account_container to application gateway integration #5290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Feb 15, 2023

What does this PR do?

Add the storage_account_container to the application gateway integration as an advanced option in the data stream.

This option is available to all other Azure Logs integration, and this one should have it too. I guess we added to others while the Application Gateway was still in development and missed syncing up.

We did this for other integrations with #3877

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

CleanShot 2023-02-15 at 17 34 12@2x

Make the `storage_account_container` option available to the Application
Gateway integration.
@zmoog zmoog added bug Something isn't working, use only for issues Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Feb 15, 2023
@zmoog zmoog self-assigned this Feb 15, 2023
@zmoog zmoog changed the title Add storage_account_container to application gateway integration [Azure Logs] Add storage_account_container to application gateway integration Feb 15, 2023
@elasticmachine
Copy link

elasticmachine commented Feb 15, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-15T16:20:30.874+0000

  • Duration: 15 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 124
Skipped 0
Total 124

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -13.636
Classes 86.364% (19/22) 👎 -13.636
Methods 83.333% (155/186) 👍 58.333
Lines 85.047% (2787/3277) 👎 -14.953
Conditionals 100.0% (0/0) 💚

@zmoog zmoog marked this pull request as ready for review February 15, 2023 16:36
@zmoog zmoog requested a review from a team as a code owner February 15, 2023 16:36
Copy link
Contributor

@girodav girodav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zmoog zmoog merged commit ff93c57 into elastic:main Feb 15, 2023
@zmoog zmoog deleted the zmoog/add-storage-account-container-option branch February 15, 2023 17:52
@elasticmachine
Copy link

Package azure - 1.5.8 containing this change is available at https://epr.elastic.co/search?package=azure

bhapas pushed a commit to bhapas/integrations that referenced this pull request Feb 16, 2023
…ntegration (elastic#5290)

* Add `storage_account_container` to application gw

Make the `storage_account_container` option available to the Application
Gateway integration.

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Azure Logs] the Application Gateway integration is missing the storage_account_container option
3 participants