Skip to content

Added dimension fields for all datastreams of Oracle Integration #5307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 1, 2023

Conversation

agithomas
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

Adding dimension fields for all datastream under Oracle Integration package to take the advantage of TSDB

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@agithomas agithomas requested a review from a team as a code owner February 16, 2023 14:26
@elasticmachine
Copy link

elasticmachine commented Feb 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-28T13:28:26.856+0000

  • Duration: 36 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 16, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (29/29) 💚 12.5
Lines 94.318% (249/264) 👍 2.338
Conditionals 100.0% (0/0) 💚

@agithomas agithomas mentioned this pull request Feb 17, 2023
21 tasks
@agithomas agithomas requested a review from ruflin February 21, 2023 10:18
@agithomas
Copy link
Contributor Author

/test

@agithomas agithomas merged commit 67c692a into elastic:main Mar 1, 2023
@elasticmachine
Copy link

Package oracle - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=oracle

agithomas added a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
…stic#5307)

* Added dimension fields for all datastreams of Oracle Integration

* Update packages/oracle/changelog.yml

Co-authored-by: Nicolas Ruflin <spam@ruflin.com>

* Addressed review comments

---------

Co-authored-by: Nicolas Ruflin <spam@ruflin.com>
agithomas added a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
…stic#5307)

* Added dimension fields for all datastreams of Oracle Integration

* Update packages/oracle/changelog.yml

Co-authored-by: Nicolas Ruflin <spam@ruflin.com>

* Addressed review comments

---------

Co-authored-by: Nicolas Ruflin <spam@ruflin.com>
@agithomas agithomas deleted the issue-4848-oracle-tsdb branch February 12, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants