[elasticsearch] Fix collection of shard recovery total time #5367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miltonhultgren
added
Integration:elasticsearch
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
…collection-shard-activity-total-time
miltonhultgren
commented
Mar 7, 2023
| @@ -1,6 +1,6 @@ | |||
| name: elasticsearch | |||
| title: Elasticsearch | |||
| version: 1.4.0 | |||
| version: 1.4.1 | |||
There was a problem hiding this comment.
@klacabane Or should I give it some kind of preview tag?
There was a problem hiding this comment.
bumping patch makes sense to me. The change is trivial and is safe to release right away
There was a problem hiding this comment.
Okay, if you can hit approve I can merge 👍🏼
miltonhultgren
commented
Mar 7, 2023
klacabane
approved these changes
Mar 7, 2023
|
Package elasticsearch - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=elasticsearch |
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 20, 2023
…5367) * [elasticsearch] Fix collection of shard recovery total time * Bump required Kibana version * Revert conditon bump
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 21, 2023
…5367) * [elasticsearch] Fix collection of shard recovery total time * Bump required Kibana version * Revert conditon bump
miltonhultgren
added a commit
to elastic/kibana
that referenced
this pull request
Mar 21, 2023
Related issue: elastic/beats#34427 Since Metricbeat now reports the right fields, I've updated the UI to consume those. <img width="2935" alt="Screenshot 2023-02-23 at 12 00 05" src="https://user-images.githubusercontent.com/2564140/220893266-1d82bc16-6bca-4eca-a5a1-1a1573eb139d.png"> Related PRs: elastic/beats#34653 elastic/elasticsearch#94062 elastic/integrations#5367 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 21, 2023
…1983) Related issue: elastic/beats#34427 Since Metricbeat now reports the right fields, I've updated the UI to consume those. <img width="2935" alt="Screenshot 2023-02-23 at 12 00 05" src="https://user-images.githubusercontent.com/2564140/220893266-1d82bc16-6bca-4eca-a5a1-1a1573eb139d.png"> Related PRs: elastic/beats#34653 elastic/elasticsearch#94062 elastic/integrations#5367 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 469c5a3)
kibanamachine
added a commit
to elastic/kibana
that referenced
this pull request
Mar 21, 2023
) (#153362) # Backport This will backport the following commits from `main` to `8.7`: - [[Monitoring] Support Metricbeat format for shard activity (#151983)](#151983) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Milton Hultgren","email":"milton.hultgren@elastic.co"},"sourceCommit":{"committedDate":"2023-03-21T12:45:46Z","message":"[Monitoring] Support Metricbeat format for shard activity (#151983)\n\nRelated issue: https://github.com/elastic/beats/issues/34427\r\n\r\nSince Metricbeat now reports the right fields, I've updated the UI to\r\nconsume those.\r\n\r\n<img width=\"2935\" alt=\"Screenshot 2023-02-23 at 12 00 05\"\r\nsrc=\"https://user-images.githubusercontent.com/2564140/220893266-1d82bc16-6bca-4eca-a5a1-1a1573eb139d.png\">\r\n\r\nRelated PRs:\r\nhttps://github.com/elastic/beats/pull/34653\r\nhttps://github.com/elastic/elasticsearch/pull/94062\r\nhttps://github.com/elastic/integrations/pull/5367\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"469c5a3761fb9cc1bf2223f38463fde37678d760","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","Feature:Stack Monitoring","backport:prev-minor","v8.8.0"],"number":151983,"url":"https://github.com/elastic/kibana/pull/151983","mergeCommit":{"message":"[Monitoring] Support Metricbeat format for shard activity (#151983)\n\nRelated issue: https://github.com/elastic/beats/issues/34427\r\n\r\nSince Metricbeat now reports the right fields, I've updated the UI to\r\nconsume those.\r\n\r\n<img width=\"2935\" alt=\"Screenshot 2023-02-23 at 12 00 05\"\r\nsrc=\"https://user-images.githubusercontent.com/2564140/220893266-1d82bc16-6bca-4eca-a5a1-1a1573eb139d.png\">\r\n\r\nRelated PRs:\r\nhttps://github.com/elastic/beats/pull/34653\r\nhttps://github.com/elastic/elasticsearch/pull/94062\r\nhttps://github.com/elastic/integrations/pull/5367\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"469c5a3761fb9cc1bf2223f38463fde37678d760"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151983","number":151983,"mergeCommit":{"message":"[Monitoring] Support Metricbeat format for shard activity (#151983)\n\nRelated issue: https://github.com/elastic/beats/issues/34427\r\n\r\nSince Metricbeat now reports the right fields, I've updated the UI to\r\nconsume those.\r\n\r\n<img width=\"2935\" alt=\"Screenshot 2023-02-23 at 12 00 05\"\r\nsrc=\"https://user-images.githubusercontent.com/2564140/220893266-1d82bc16-6bca-4eca-a5a1-1a1573eb139d.png\">\r\n\r\nRelated PRs:\r\nhttps://github.com/elastic/beats/pull/34653\r\nhttps://github.com/elastic/elasticsearch/pull/94062\r\nhttps://github.com/elastic/integrations/pull/5367\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"469c5a3761fb9cc1bf2223f38463fde37678d760"}}]}] BACKPORT--> Co-authored-by: Milton Hultgren <milton.hultgren@elastic.co>
![https://user-images.githubusercontent.com/2564140/220893266-1d82bc16-6bca-4eca-a5a1-1a1573eb139d.png\">\r\n\r\nRelated](https://app.smartcontext.ai/default/https://user-images.githubusercontent.com/2564140/220893266-1d82bc16-6bca-4eca-a5a1-1a1573eb139d.png/">/r/n/r/nRelated){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This cannot be tested until the Metricbeat changes are merged.
Related issue: elastic/beats#34427
Since Metricbeat now reports the total time for a recovery, I've added a missing alias.
Related PRs:
elastic/elasticsearch#94062
elastic/kibana#151983