Skip to content

[MySQL][TSDB] Add metric type mapping for performance datastream #5378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 16, 2023

Conversation

agithomas
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

Add metric_type mapping for Performance datastream of MySQL

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Install / upgrade the integration package
  • Verify the data in dashboard and in discover view.

Related issues

@agithomas agithomas requested a review from a team as a code owner February 24, 2023 09:11
@agithomas agithomas self-assigned this Feb 24, 2023
@agithomas agithomas force-pushed the issue-5277-mysql-metrictype branch from 3558db8 to 709b5c0 Compare February 24, 2023 09:16
@agithomas agithomas mentioned this pull request Feb 24, 2023
19 tasks
@elasticmachine
Copy link

elasticmachine commented Feb 24, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-16T09:04:07.894+0000

  • Duration: 32 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 74
Skipped 0
Total 74

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 24, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 85.714% (24/28)
Lines 93.706% (134/143)
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 2050aaa into elastic:main Mar 16, 2023
@elasticmachine
Copy link

Package mysql - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=mysql

agithomas added a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
agithomas added a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@agithomas agithomas deleted the issue-5277-mysql-metrictype branch February 12, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants