cloudflare: drop empty event sets #5406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
efd6
force-pushed
the
5392-cloudflare
branch
from
e680107 to
0ba3d74
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
bhapas
reviewed
Mar 1, 2023
| @@ -10,6 +10,8 @@ processors: | |||
| - json: | |||
| field: event.original | |||
| target_field: json | |||
| - drop: | |||
| if: ctx.json?.result != null && ctx.json.result.isEmpty() | |||
There was a problem hiding this comment.
Not sure if this ever happens?
Shouldn't the event be dropped even if result object is null ?
There was a problem hiding this comment.
From the issue, the empty case has a result: []. If we drop when result == null we will lose all documents since the actual events don't have a result field.
|
Package cloudflare - 2.4.1 containing this change is available at https://epr.elastic.co/search?package=cloudflare |
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 20, 2023
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Drop empty event sets.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots