Skip to content

[Azure Monitor] Fix dimensions for CassandraConnectionClosures #5465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2023

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Mar 7, 2023

What does this PR do?

Move the CassandraConnectionClosures metric into a dedicated query section using the supported dimension ClosureReason instead of the unsupported DatabaseName.

Why is this important?

We must remediate an error introduced in the previous PR when we put the CassandraConnectionClosures metric name together with other Cassandra-related metrics using the DatabaseName dimension.

This can work under some circumstances — that's why we didn't spot the problem!

Unfortunately, this can cause an error since the CassandraConnectionClosures supports only the ClosureReason and Region dimensions.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@elasticmachine
Copy link

elasticmachine commented Mar 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-08T14:58:04.907+0000

  • Duration: 13 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 134
Skipped 0
Total 134

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 73.333% (22/30) 👎 -26.667
Lines 100.0% (21/21) 💚 12.621
Conditionals 100.0% (0/0) 💚

@zmoog zmoog self-assigned this Mar 8, 2023
@zmoog zmoog added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Mar 8, 2023
@zmoog zmoog changed the title Fix dimensions for CassandraConnectionClosures [Azure Monitor] Fix dimensions for CassandraConnectionClosures Mar 8, 2023
@zmoog zmoog force-pushed the zmoog/azure-metrics-cassandra branch from 200cd64 to fce4846 Compare March 8, 2023 14:57
@zmoog zmoog marked this pull request as ready for review March 8, 2023 15:20
@zmoog zmoog requested a review from a team as a code owner March 8, 2023 15:20
@zmoog zmoog added the bug Something isn't working, use only for issues label Mar 8, 2023
@zmoog zmoog merged commit 86b5729 into main Mar 8, 2023
@zmoog zmoog deleted the zmoog/azure-metrics-cassandra branch March 8, 2023 17:50
@elasticmachine
Copy link

Package azure_metrics - 1.0.15 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants