Skip to content

[AWS] Migrate ELB metrics dashboard visualizations to lenses #5643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 7, 2023
Merged

[AWS] Migrate ELB metrics dashboard visualizations to lenses #5643

merged 8 commits into from
Jun 7, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Mar 22, 2023

What does this PR do?

Migrates visualizations to lenses and adds input control groups.

Before:
elb_before

After:
elb_after

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 added Team:Cloud-Monitoring Label for the Cloud Monitoring team Integration:aws AWS labels Mar 22, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-07T20:14:22.206+0000

  • Duration: 59 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 190
Skipped 4
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👍
Classes 93.75% (15/16) 👍
Methods 85.921% (238/277) 👍
Lines 85.925% (7387/8597) 👍
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review March 22, 2023 20:55
@gpop63 gpop63 requested review from a team as code owners March 22, 2023 20:55
drewdaemon
drewdaemon reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use the Lens metric instead of the legacy metric?

@botelastic
Copy link

botelastic bot commented Apr 26, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Apr 26, 2023
@botelastic botelastic bot removed the Stalled label May 14, 2023
@gpop63
Copy link
Contributor Author

gpop63 commented May 14, 2023

Replaced legacy metric charts, here's how it looks:

elb_metric_charts

@drewdaemon
Copy link
Contributor

Looking good! @gvnmagni any further layout suggestions here?

@drewdaemon
Copy link
Contributor

From meeting

  • collapse first two layout lines into one
    • stack metric charts

@gpop63 gpop63 self-assigned this May 22, 2023
@gpop63
Copy link
Contributor Author

gpop63 commented May 29, 2023

This is how it looks now - do you think the metric charts are too wide? @drewdaemon

aws_elb_new_layout

drewdaemon
drewdaemon approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpop63 I think they look good. You have a particularly wide screen, so if it looks okay on yours, it probably looks good on smaller screens as well 👍

@gpop63 gpop63 merged commit 0e59fb8 into elastic:main Jun 7, 2023
@elasticmachine
Copy link

Package aws - 1.40.9 containing this change is available at https://epr.elastic.co/search?package=aws

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@gpop63 @sodhikirti07
[AWS] Migrate ELB metrics dashboard visualizations to lenses (#5643)
429f031 
* add lenses and input control group

* bump package version

* replace legacy with metric charts

* stack first two rows

* fix layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees

@gpop63 gpop63

Labels
Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gpop63 @elasticmachine @drewdaemon @zmoog