Skip to content

[O11y][Microsoft SQL Server] Lens migration for visualizations to Kibana version 8.4.0 #5733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 29, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Microsoft SQL Server integration package

  • Statistics for Microsoft SQL Server Lens migration:

Microsoft SQL Server dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Logs Microsoft SQL Server Audit Events] Overview 7 0 7 0
[Logs Microsoft SQL Server] Error Log Overview 1 0 1 0
[Metrics Microsoft SQL Server] Performance 5 0 5 0
  13 0 13 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

Note: All the panels were created in lens previously, but we have exported it from 8.4.0 so this PR will only contain metadata changes.

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 29, 2023 11:58
@kush-elastic kush-elastic added enhancement New feature or request Integration:microsoft_sqlserver Microsoft SQL Server v8.4.0 Team:Service-Integrations Label for the Observability Service Integrations team labels Mar 29, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 29, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-29T12:03:14.468+0000

  • Duration: 16 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 93.333% (28/30) 👍 2.029
Lines 100.0% (1238/1238) 💚 17.526
Conditionals 100.0% (0/0) 💚

@milan-elastic
Copy link
Contributor

Thanks @rajvi-elastic ! Approved!

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@kush-elastic kush-elastic self-requested a review March 31, 2023 06:24
Copy link
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit f617a1d into elastic:main Mar 31, 2023
@elasticmachine
Copy link

Package microsoft_sqlserver - 1.18.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:microsoft_sqlserver Microsoft SQL Server Team:Service-Integrations Label for the Observability Service Integrations team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants