Skip to content

[O11y][Microsoft SQL Server] Lens migration for Transaction log dashboard visualizations to Kibana version 8.4.0 #5734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 31, 2023
Merged

[O11y][Microsoft SQL Server] Lens migration for Transaction log dashboard visualizations to Kibana version 8.4.0 #5734

merged 4 commits into from
Mar 31, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 29, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Microsoft SQL Server integration package

  • Statistics for Microsoft SQL Server Lens migration:

Microsoft SQL Server dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization New control Panel
[Metrics Microsoft SQL Server] Transaction log 0 8 7 0 1
  0 8 7 0 1

Note: 1 visualization is migrated to new control panels.

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 29, 2023 11:59
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 29, 2023
Closed
8 tasks
@kush-elastic kush-elastic added enhancement New feature or request v8.4.0 Team:Service-Integrations Label for the Observability Service Integrations team Integration:microsoft_sqlserver Microsoft SQL Server labels Mar 29, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 29, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-31T10:46:11.492+0000

  • Duration: 16 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 29, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 93.333% (28/30) 👍 5.833
Lines 100.0% (1238/1238) 💚 8.02
Conditionals 100.0% (0/0) 💚

@milan-elastic
Copy link
Contributor

Thanks @rajvi-elastic ! Approved!

@muthu-mps
Copy link
Contributor

@rajvi-elastic - Before and after migration doesn't include the control panel filter and you please add that to the table.

@rajvi-patel-22
Copy link
Contributor Author

@rajvi-elastic - Before and after migration doesn't include the control panel filter and you please add that to the table.

@muthu-mps Update the description in PR and issue as well.

@kush-elastic kush-elastic self-requested a review March 31, 2023 06:23
kush-elastic
kush-elastic approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

muthu-mps
muthu-mps approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rajvi-patel-22
Merge branch 'main' of github.com:rajvi-elastic/integrations into len…
c4eb170 
…s_migration-microsoft_sqlserver-transaction-log-8.4.0
@rajvi-patel-22
Merge branch 'main' of github.com:rajvi-elastic/integrations into len…
29929d0 
…s_migration-microsoft_sqlserver-transaction-log-8.4.0
@kush-elastic kush-elastic merged commit 06adb31 into elastic:main Mar 31, 2023
@elasticmachine
Copy link

Package microsoft_sqlserver - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kush-elastic kush-elastic kush-elastic approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:microsoft_sqlserver Microsoft SQL Server Team:Service-Integrations Label for the Observability Service Integrations team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajvi-patel-22 @elasticmachine @milan-elastic @muthu-mps @kush-elastic