Skip to content

[AWS] Add missing permissions required by the CloudWatch logs integration #5790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Apr 4, 2023

What does this PR do?

Add two missing permissions to the AWS integration docs.

  • logs:DescribeLogGroups
  • logs:FilterLogEvents

The AWS CloudWatch logs input requires these permissions to fetch logs from the CloudWatch API.

The additional permissions come from the AWS CloudWatch input docs for Filebeat.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@zmoog zmoog self-assigned this Apr 4, 2023
@zmoog zmoog added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Apr 4, 2023
@zmoog zmoog changed the title [AWS] Add missing logs:FilterLogEvents permission [AWS] Add missing permissions required by the CloudWatch logs integration Apr 4, 2023
@zmoog zmoog marked this pull request as ready for review April 4, 2023 15:38
@zmoog zmoog requested a review from a team as a code owner April 4, 2023 15:38
@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-06T14:22:29.587+0000

  • Duration: 53 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 86.131% (236/274) 👎 -2.834
Lines 85.925% (7387/8597) 👎 -9.331
Conditionals 100.0% (0/0) 💚

zmoog added 2 commits April 6, 2023 16:17
The AWS CloudWatch logs input needs this permission to fetch logs
from the CloudWatch API.
@zmoog zmoog force-pushed the zmoog/add-missing-cloudwatch-logs-permission branch from 5a414bf to ba1b1f7 Compare April 6, 2023 14:18
@zmoog zmoog force-pushed the zmoog/add-missing-cloudwatch-logs-permission branch from ba1b1f7 to 9c9ce8e Compare April 6, 2023 14:22
@zmoog zmoog merged commit 4047e8e into main Apr 6, 2023
@zmoog zmoog deleted the zmoog/add-missing-cloudwatch-logs-permission branch April 6, 2023 15:24
@elasticmachine
Copy link

Package aws - 1.33.1 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants