Skip to content

Universal Profiling: add package for symbolizer #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Conversation

florianl
Copy link
Member

What does this PR do?

Add a package for Universal Profiling Symbolizer

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@florianl florianl added enhancement New feature or request v8.8.0 labels Apr 13, 2023
@elasticmachine
Copy link

elasticmachine commented Apr 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-24T07:03:30.508+0000

  • Duration: 15 min 44 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@florianl florianl force-pushed the flo-up-symbolizer branch from 3085d6e to c0bd832 Compare April 17, 2023 06:40
@florianl florianl force-pushed the flo-up-symbolizer branch from c0bd832 to 4a08952 Compare April 17, 2023 15:36
@florianl florianl force-pushed the flo-up-symbolizer branch from 4a08952 to 59deb21 Compare April 18, 2023 08:33
@florianl florianl marked this pull request as ready for review April 18, 2023 09:05
@kpollich kpollich self-requested a review April 18, 2023 11:38
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Comment on lines +23 to +28
vars:
- name: hack
type: bool
title: hack to workaround a known issue
description: |
Check out elastic/kibana/issues/155064 for the reason of this hack.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to remove this once elastic/kibana#155079 lands

Copy link
Contributor

@inge4pres inge4pres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor non-blocking comment.
Thanks for creating this 🙏🏼
As soon as it is merged, I think we can test it in Cloud.

- name: universal_profiling_symbolizer
title: Universal Profiling Symbolization Service
description: Interact with Universal Profiling.
inputs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshdover is it here we need to add the data stream?

conditions:
kibana.version: ^8.8.0
elastic.subscription: basic
format_version: 1.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be upgraded to 2.7.0 to support the new data stream, once we add it

florianl and others added 3 commits April 24, 2023 09:02
Signed-off-by: Florian Lehner <flehner@optimyze.cloud>
Co-authored-by: Francesco Gualazzi <inge4pres@users.noreply.github.com>
Signed-off-by: Florian Lehner <flehner@optimyze.cloud>
@florianl florianl force-pushed the flo-up-symbolizer branch from de6c116 to 7383033 Compare April 24, 2023 07:03
@florianl florianl merged commit 71947e0 into main Apr 24, 2023
@elasticmachine
Copy link

Package profiler_symbolizer - 8.8.0-preview containing this change is available at https://epr.elastic.co/search?package=profiler_symbolizer

@andrewkroh andrewkroh added the Integration:universal_profiling_symbolizer Universal Profiling Symbolizer label Jul 22, 2024
@florianl florianl deleted the flo-up-symbolizer branch August 12, 2024 11:56
@andrewkroh andrewkroh added the New Integration Issue or pull request for creating a new integration package. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:universal_profiling_symbolizer Universal Profiling Symbolizer New Integration Issue or pull request for creating a new integration package. v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants