Skip to content

[O11y][Oracle] Fix aggregation of Performance data stream visualization #5892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2023
Merged

[O11y][Oracle] Fix aggregation of Performance data stream visualization #5892

merged 2 commits into from
Apr 18, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Apr 17, 2023 •
edited
Loading

  • Bug

What does this PR do?

  • Changes related to normalization by unit formula to match the data count with TSVB.
  • Minor change in description of changelog.yml

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner April 17, 2023 07:38
@kush-elastic kush-elastic added bug Something isn't working, use only for issues Team:Service-Integrations Label for the Observability Service Integrations team labels Apr 17, 2023
@elasticmachine
Copy link

elasticmachine commented Apr 17, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-17T07:40:28.739+0000

  • Duration: 30 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (29/29) 💚
Lines 94.318% (249/264) ❕
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic self-requested a review April 17, 2023 10:34
kush-elastic
kush-elastic approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor

Can you please link the PR to the original issue?

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 18, 2023
Closed
@rajvi-patel-22
Copy link
Contributor Author

Can you please link the PR to the original issue?

@agithomas, I have added link to the issue: #5906

agithomas
agithomas approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit d3bdb16 into elastic:main Apr 18, 2023
@elasticmachine
Copy link

Package oracle - 1.17.1 containing this change is available at https://epr.elastic.co/search?package=oracle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kush-elastic kush-elastic kush-elastic approved these changes

@agithomas agithomas agithomas approved these changes

@milan-elastic milan-elastic milan-elastic approved these changes

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues Integration:oracle Oracle Team:Service-Integrations Label for the Observability Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajvi-patel-22 @elasticmachine @agithomas @kush-elastic @milan-elastic