Skip to content

[AWS][ECS] Add ECS metric types for TSDB support #5968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 4, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

Add field metric type to the ECS data stream for TSDB support.

Details

All metrics are gauge as they both increment and decrement.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Refer to #5894

Related issues

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m added enhancement New feature or request Integration:aws AWS labels Apr 24, 2023
@constanca-m constanca-m requested a review from a team as a code owner April 24, 2023 07:19
@constanca-m constanca-m self-assigned this Apr 24, 2023
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m mentioned this pull request Apr 24, 2023
5 tasks
@elasticmachine
Copy link

elasticmachine commented Apr 24, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-04T08:25:01.228+0000

  • Duration: 52 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 24, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👍
Classes 93.75% (15/16) 👍
Methods 86.131% (236/274) 👍
Lines 85.925% (7387/8597) 👍
Conditionals 100.0% (0/0) 💚

constanca-m and others added 2 commits May 4, 2023 10:10
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m merged commit 75837de into elastic:main May 4, 2023
@constanca-m constanca-m deleted the ecs-add-metric branch May 4, 2023 09:21
@elasticmachine
Copy link

Package aws - 1.34.3 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:aws AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants