Skip to content

Added dimensions for AWS Redshift #6083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 18, 2023

Conversation

agithomas
Copy link
Contributor

What does this PR do?

Add dimension fields to Redshift datastream.

Details

Amazon Redshift data can be filtered along any of the dimensions below ( Reference ) and hence these fields are needed to be added as dimension fields.

  • latency
  • NodeID
  • ClusterIdentifier
  • service_class
  • stage
  • wlmid
  • QueryPriority
  • QueueName

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Refer to #6082

Related issues

@agithomas agithomas mentioned this pull request May 4, 2023
5 tasks
@elasticmachine
Copy link

elasticmachine commented May 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-18T06:39:12.365+0000

  • Duration: 54 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👍
Classes 93.75% (15/16) 👍
Methods 86.131% (236/274) 👍
Lines 85.925% (7387/8597) 👍
Conditionals 100.0% (0/0) 💚

@agithomas agithomas marked this pull request as ready for review May 4, 2023 07:14
@agithomas agithomas requested a review from a team as a code owner May 4, 2023 07:14
@constanca-m
Copy link
Contributor

I noticed that you bumped the version to 1.35.0, but I have been just incrementing the last number.

@agithomas
Copy link
Contributor Author

I noticed that you bumped the version to 1.35.0, but I have been just incrementing the last number.

Sure, i will follow 1.34.x going forward and will be addressed as part of resolving merge conflict.

@agithomas
Copy link
Contributor Author

/test

@agithomas agithomas merged commit d369c12 into elastic:main May 18, 2023
@elasticmachine
Copy link

Package aws - 1.36.3 containing this change is available at https://epr.elastic.co/search?package=aws

@agithomas agithomas deleted the issue-6082-awsredshift-dimensions branch February 12, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants