-
Notifications
You must be signed in to change notification settings - Fork 474
[Auditd_Manager] fixing wrong field type for auditd.data.exit #6111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a test expectation update.
(FYI) This looks like it will resolve #4860 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exit code is always a string in the JSON from auditbeat. go-libaudit
translates numbers to named POSIX exit codes if possible.
Package auditd_manager - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=auditd_manager |
What does this PR do?
Fixes wrong field type for
auditd.data.exit
. It was keyword in auditbeat and seems to convert to a keyword/string value if the integer value is known, or the exit code is a string by itself.Checklist
changelog.yml
file.Related issues
illegal_argument_exception
#4860