Skip to content

[Tomcat] Remove localhost dashboard and update titles of saved searches #6127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

niraj-elastic
Copy link
Contributor

  • Bug

What does this PR do?

  • Remove unnecessary dashboard from Localhost data stream as it is already combined with catalina datastream.
  • Change internal title of saved searches.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/apache_tomcat) directory.
  • Run the following command to run tests. elastic-package test

@niraj-elastic niraj-elastic changed the title [Tomcat] Remove localhost dashboard and update titles of saved searchesPackage apache tomcat remove dashboard [Tomcat] Remove localhost dashboard and update titles of saved searches May 9, 2023
@kush-elastic kush-elastic added enhancement New feature or request Integration:apache_tomcat Apache Tomcat Team:Service-Integrations Label for the Observability Service Integrations team labels May 9, 2023
@elasticmachine
Copy link

elasticmachine commented May 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-09T12:45:06.568+0000

  • Duration: 21 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 30
Skipped 0
Total 30

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚
Classes 100.0% (5/5) 💚
Methods 92.308% (48/52) 👍 0.844
Lines 83.011% (386/465) 👎 -5.952
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic marked this pull request as ready for review May 9, 2023 13:08
@kush-elastic kush-elastic requested a review from a team as a code owner May 9, 2023 13:08
@kush-elastic kush-elastic merged commit 244a131 into elastic:main May 9, 2023
@elasticmachine
Copy link

Package apache_tomcat - 0.5.1 containing this change is available at https://epr.elastic.co/search?package=apache_tomcat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:apache_tomcat Apache Tomcat Team:Service-Integrations Label for the Observability Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants