Skip to content

[MSSQL] Update dimensions #6143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2023
Merged

[MSSQL] Update dimensions #6143

merged 2 commits into from
May 11, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented May 10, 2023 •
edited
Loading

  • Bug

What does this PR do?

Modify the dimension field mapping to support public cloud deployment and added few datastream specific dimensions.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ritalwar ritalwar mentioned this pull request May 10, 2023
Closed
12 tasks
@ritalwar ritalwar marked this pull request as ready for review May 10, 2023 12:04
@ritalwar ritalwar requested a review from a team as a code owner May 10, 2023 12:04
@ritalwar ritalwar changed the title Update some cloud dimensions Update dimensions May 10, 2023
@elasticmachine
Copy link

elasticmachine commented May 10, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-10T12:02:50.301+0000

  • Duration: 22 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 93.333% (28/30) ❕
Lines 100.0% (1238/1238) 💚
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar changed the title Update dimensions [MSSQL] Update dimensions May 11, 2023
agithomas
agithomas approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit 59f6c21 into elastic:main May 11, 2023
@elasticmachine
Copy link

Package microsoft_sqlserver - 1.19.1 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

@andrewkroh andrewkroh added the Integration:microsoft_sqlserver Microsoft SQL Server label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

Assignees
No one assigned
Labels
Integration:microsoft_sqlserver Microsoft SQL Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ritalwar @elasticmachine @agithomas @andrewkroh