-
Notifications
You must be signed in to change notification settings - Fork 474
Add missing field definitions for the SQLServer integration #6264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing field definitions for the SQLServer integration #6264
Conversation
34847a5
to
c5283d7
Compare
🌐 Coverage report
|
Lets add in some other common agent.yml fields as well, we have some covering add_*_metadata like container and cloud in most of our integrations, compare this with for example checkpoint. Rest LGTM! |
7e5065b
to
1bf4967
Compare
Thanks for the review. I also realized that the host and message fields were missing in the remaining data streams and the events could contain those fields so I added them as well. |
/test |
1bf4967
to
601683c
Compare
Found a bug when processing the ![]() so I have added the necessary processors in the ingest pipeline to meet the ECS format in case the field appears: 601683c |
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
601683c
to
a6e019b
Compare
Package microsoft_sqlserver - 1.22.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver |
What does this PR do?
It adds the following changes:
Audit data stream
ecs.yml
. Otherwise, they have been added atagent.yml
along with missing fields forcloud
andcontainer
.host.os.name
is defined in ECS, it has been included inagent.yml
to avoid a conflict in the type of thetext
multi_field (text
vsmatch_only_text
) with the Log data stream.Log data stream
host
ECS fields defined atagent.yml
have been moved toecs.yml
for consistency.Performance data stream
cloud
andcontainer
fields in agent.yml.host
fields in ecs.yml for consistency.Transaction logs data stream
cloud
andcontainer
fields in agent.yml.host
fields in ecs.yml for consistency.Checklist
changelog.yml
file.Related issues
Screenshots