Skip to content

[Kubernetes][Dashboard] Update volume dashboard #6292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

When TSDB is disabled, there is a visualization that appears like this:

image

However, when enabling TSDB, the visualization stops working since "it is not possible to filter by kubernetes.volume.fs.used.pct: *". This PR fixes that so the visualization works the same in both modes.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m requested a review from a team as a code owner May 23, 2023 07:50
@constanca-m constanca-m self-assigned this May 23, 2023
@constanca-m constanca-m requested a review from a team as a code owner May 23, 2023 07:50
@constanca-m constanca-m requested review from gizas and gsantoro May 23, 2023 07:50
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

elasticmachine commented May 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-23T07:51:35.910+0000

  • Duration: 28 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 92
Skipped 0
Total 92

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 96.154% (75/78) 👍 2.036
Lines 100.0% (0/0) 💚 1.559
Conditionals 100.0% (0/0) 💚

@constanca-m constanca-m merged commit 5c096ee into elastic:main May 24, 2023
@constanca-m constanca-m deleted the fix-volume-dashboard branch May 24, 2023 14:02
@elasticmachine
Copy link

Package kubernetes - 1.40.0-beta.2 containing this change is available at https://epr.elastic.co/search?package=kubernetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants