Skip to content

[Cloudflare] New dashboards using Lens, and bumping format version #6370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 1, 2023

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented May 30, 2023

What does this PR do?

This PR remakes the existing dashboards into using Lens, and updates its styling and layout to match other new dashboards.
I also updated the format_version, and added pipeline errors.
Updated some extra fields from the test data to have better coverage.
Fixed some small bugs and added some small additions to the pipeline to fit the dashboards.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Overview:
cloudflare-overview1
Overview2

Clients:
Clients1

Content:
Content1

Reliability
Rel1
Rel2

Performance:
cloudflare-perf1
Perf2

Security overview:
cloudflare-sec1
Seco2

Ratelimit:
ratelimit1

WAF:
waf1
waf2

@P1llus P1llus added enhancement New feature or request Team:Security-External Integrations Integration:cloudflare Cloudflare (Community supported) labels May 30, 2023
@P1llus P1llus requested a review from a team as a code owner May 30, 2023 15:23
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented May 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-01T13:52:12.682+0000

  • Duration: 19 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 30, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 100.0% (38/38) 💚
Lines 94.73% (701/740)
Conditionals 100.0% (0/0) 💚

@efd6
Copy link
Contributor

efd6 commented May 30, 2023

Minor suggestions/queries.

  1. In the overview because of the alignment of the counters with the pie charts, it looks like they are associated pairwise (counter with pie chart). This is not true, so is there some way to visually break that association.
  2. In ratelimit, the top left pie chart can be narrower, giving up space to the table.

Out-of-scope-concern: I'm still troubled by how lens counters reduce data impact by avoiding the central space.

@P1llus
Copy link
Member Author

P1llus commented Jun 1, 2023

Minor suggestions/queries.

  1. In the overview because of the alignment of the counters with the pie charts, it looks like they are associated pairwise (counter with pie chart). This is not true, so is there some way to visually break that association.
  2. In ratelimit, the top left pie chart can be narrower, giving up space to the table.

Out-of-scope-concern: I'm still troubled by how lens counters reduce data impact by avoiding the central space.

Added in your changes, though I did not want to re-add my custom input config again just for some test data, I can show that the sizes and placements has changed:

Overview, grouped them side by-side instead, which still makes sense.
Overview changed

Rate Limit just made it less wide, but a little bit higher to compensate:
ratechanged

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks. LGTM 📈

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks. LGTM 📈

@P1llus
Copy link
Member Author

P1llus commented Jun 1, 2023

Added the nitpicks as well, though one referenced lines from the old state of the viz, so the actual change happened elsewhere. Will merge soon if nothing else comes up.

@P1llus P1llus merged commit f91d726 into elastic:main Jun 1, 2023
@elasticmachine
Copy link

Package cloudflare - 2.8.0 containing this change is available at https://epr.elastic.co/search?package=cloudflare

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
…6370)

* stashing changes

* stash changes

* stashing changes

* initial finalized commit for rebuilding the dashboards to lens

* updating dashboards from merge

* update overview and ratelimit based on PR comment

* update some viz titles based on PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:cloudflare Cloudflare (Community supported)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants