-
Notifications
You must be signed in to change notification settings - Fork 474
[Cloudflare] New dashboards using Lens, and bumping format version #6370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloudflare] New dashboards using Lens, and bumping format version #6370
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🌐 Coverage report
|
Minor suggestions/queries.
Out-of-scope-concern: I'm still troubled by how lens counters reduce data impact by avoiding the central space. |
Added in your changes, though I did not want to re-add my custom input config again just for some test data, I can show that the sizes and placements has changed: Overview, grouped them side by-side instead, which still makes sense. Rate Limit just made it less wide, but a little bit higher to compensate: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicks. LGTM 📈
packages/cloudflare/kibana/dashboard/cloudflare-5a5d6b80-49b9-11e9-bd1f-75f359ac0c3f.json
Outdated
Show resolved
Hide resolved
packages/cloudflare/kibana/dashboard/cloudflare-5a5d6b80-49b9-11e9-bd1f-75f359ac0c3f.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicks. LGTM 📈
Added the nitpicks as well, though one referenced lines from the old state of the viz, so the actual change happened elsewhere. Will merge soon if nothing else comes up. |
Package cloudflare - 2.8.0 containing this change is available at https://epr.elastic.co/search?package=cloudflare |
…6370) * stashing changes * stash changes * stashing changes * initial finalized commit for rebuilding the dashboards to lens * updating dashboards from merge * update overview and ratelimit based on PR comment * update some viz titles based on PR comments
What does this PR do?
This PR remakes the existing dashboards into using Lens, and updates its styling and layout to match other new dashboards.
I also updated the format_version, and added pipeline errors.
Updated some extra fields from the test data to have better coverage.
Fixed some small bugs and added some small additions to the pipeline to fit the dashboards.
Checklist
changelog.yml
file.Related issues
Screenshots
Overview:


Clients:

Content:

Reliability


Performance:


Security overview:


Ratelimit:

WAF:

