[System] [Network] Add dimensions and clean up duplicated fields definition #6405

tetianakravchenko · 2023-05-31T13:42:07Z

What does this PR do?

This is a follow up PR of #6118 (comment)
In this PR:

added dimensions to the network data_stream: additionally to the default list of dimensions, must be added system.network.name
cleaned up duplicated fields

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

[ ]

How to test this PR locally

Related issues

Relates [System] Add dimensions to system package metrics data_streams only, except core data_streams #6118

Screenshots

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

tetianakravchenko · 2023-05-31T13:45:58Z

packages/system/data_stream/network/fields/agent.yml

@@ -195,26 +195,3 @@
      example: "stretch"
      description: >
        OS codename, if any.
-
-    - name: network.in.bytes


those fields are repeated in fields/ twice: in agent.yml and in fields.yml

tetianakravchenko · 2023-05-31T13:46:32Z

packages/system/data_stream/network/fields/base-fields.yml

@@ -7,9 +7,6 @@
 - name: data_stream.namespace
  type: constant_keyword
  description: Data stream namespace.
- name: '@timestamp'


repeated in ecs.yml https://github.com/elastic/integrations/pull/6405/files#diff-b76aed736a60d76fd3ebe52357896a07a3f735ea06b403aafc104a9b8f3b8f7dL2

tetianakravchenko · 2023-05-31T13:47:16Z

packages/system/data_stream/network/fields/fields.yml

@@ -53,25 +54,25 @@
  type: group
  fields:
    - name: network.in.bytes
-      type: scaled_float


see this comment for reference - #6118 (comment)

My understanding based on the previous comments is that the only affect this has is on the docs page, everything else already had long. Correct?

Yes, I have the same understanding, all the host.network.in.*, host.network.out.* are of type long when instaling package:

elasticmachine · 2023-05-31T13:57:10Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-06-01T15:54:41.513+0000
Duration: 15 min 8 sec

Test stats 🧪

Test	Results
Failed	0
Passed	145
Skipped	0
Total	145

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

elasticmachine · 2023-05-31T13:57:21Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`3/3`)	💚
Files	100.0% (`4/4`)	💚
Classes	100.0% (`4/4`)	💚
Methods	60.759% (`48/79`)	👎 -21.321
Lines	99.536% (`2790/2803`)	👍 2.501
Conditionals	100.0% (`0/0`)	💚

ruflin · 2023-06-01T06:49:25Z

packages/system/changelog.yml

@@ -1,4 +1,9 @@
 # newer versions go on top
+- version: "1.30.0"


Same as other PR, conflicting version number?

fixed in 57547c7

ruflin

Change LGTM.

But see my comment around package version.

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

agithomas

LGTM!

elasticmachine · 2023-06-05T08:54:26Z

Package system - 1.32.0-beta.1 containing this change is available at https://epr.elastic.co/search?package=system

…nition (#6405) * add dimensions and clean up duplicated fields definition Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * fix pr link in changelog Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> --------- Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

add dimensions and clean up duplicated fields definition

a1fec78

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

tetianakravchenko requested a review from a team as a code owner May 31, 2023 13:42

tetianakravchenko requested review from rdner and cmacknz May 31, 2023 13:42

fix pr link in changelog

b4149ef

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

tetianakravchenko requested review from leehinman and agithomas May 31, 2023 13:43

tetianakravchenko commented May 31, 2023

View reviewed changes

tetianakravchenko mentioned this pull request May 31, 2023

Enable TSDB for System integration #5848

Closed

11 tasks

tetianakravchenko mentioned this pull request May 31, 2023

[System] Add dimensions to system package metrics data_streams only, except core data_streams #6118

Merged

4 tasks

ruflin reviewed Jun 1, 2023

View reviewed changes

fix conflicts; update version of system package

57547c7

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

ruflin approved these changes Jun 1, 2023

View reviewed changes

tetianakravchenko requested a review from fearful-symmetry June 1, 2023 14:06

leehinman approved these changes Jun 1, 2023

View reviewed changes

Merge branch 'main' into system-network-dimensions

d0640c0

agithomas approved these changes Jun 2, 2023

View reviewed changes

tetianakravchenko merged commit 68dd768 into elastic:main Jun 5, 2023

tetianakravchenko deleted the system-network-dimensions branch June 5, 2023 08:34

andrewkroh added the Integration:system System label Jul 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[System] [Network] Add dimensions and clean up duplicated fields definition #6405

[System] [Network] Add dimensions and clean up duplicated fields definition #6405

Uh oh!

tetianakravchenko commented May 31, 2023 •

edited

Loading

Uh oh!

tetianakravchenko May 31, 2023

Uh oh!

tetianakravchenko May 31, 2023

Uh oh!

tetianakravchenko May 31, 2023

Uh oh!

ruflin Jun 1, 2023

Uh oh!

tetianakravchenko Jun 1, 2023

Uh oh!

elasticmachine commented May 31, 2023 •

edited

Loading

Build stats

Test stats 🧪

Uh oh!

elasticmachine commented May 31, 2023 •

edited

Loading

Uh oh!

ruflin Jun 1, 2023

Uh oh!

tetianakravchenko Jun 1, 2023

Uh oh!

ruflin left a comment

Uh oh!

agithomas left a comment

Uh oh!

elasticmachine commented Jun 5, 2023

Uh oh!

Uh oh!

		@@ -1,4 +1,9 @@
		# newer versions go on top
		- version: "1.30.0"

[System] [Network] Add dimensions and clean up duplicated fields definition #6405

[System] [Network] Add dimensions and clean up duplicated fields definition #6405

Uh oh!

Conversation

tetianakravchenko commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Checklist

Author's Checklist

How to test this PR locally

Related issues

Screenshots

Uh oh!

tetianakravchenko May 31, 2023

Choose a reason for hiding this comment

Uh oh!

tetianakravchenko May 31, 2023

Choose a reason for hiding this comment

Uh oh!

tetianakravchenko May 31, 2023

Choose a reason for hiding this comment

Uh oh!

ruflin Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

tetianakravchenko Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

Uh oh!

elasticmachine commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

Uh oh!

ruflin Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

tetianakravchenko Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

ruflin left a comment

Choose a reason for hiding this comment

Uh oh!

agithomas left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jun 5, 2023

Uh oh!

Uh oh!

tetianakravchenko commented May 31, 2023 •

edited

Loading

elasticmachine commented May 31, 2023 •

edited

Loading

elasticmachine commented May 31, 2023 •

edited

Loading