Skip to content

[cisco_asa,cisco_ftd] Fix VPN event.action #6423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 1, 2023
Merged

[cisco_asa,cisco_ftd] Fix VPN event.action #6423

merged 5 commits into from
Jun 1, 2023

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Jun 1, 2023 •
edited
Loading

What does this PR do?

Fixes event.action field for specific VPN event ID's.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@LaZyDK LaZyDK requested a review from a team as a code owner June 1, 2023 10:57
@LaZyDK
Copy link
Contributor Author

LaZyDK commented Jun 1, 2023

No change was made to the ASA dashboard. The system tests regenerated it.

@P1llus
Copy link
Member

P1llus commented Jun 1, 2023

/test

@elasticmachine
Copy link

elasticmachine commented Jun 1, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-01T12:33:19.981+0000

  • Duration: 18 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 45
Skipped 0
Total 45

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 1, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.004
Classes 100.0% (2/2) 💚 3.004
Methods 100.0% (40/40) 💚 8.267
Lines 78.407% (3297/4205) 👎 -13.609
Conditionals 100.0% (0/0) 💚

@P1llus
Copy link
Member

P1llus commented Jun 1, 2023

/test

@P1llus P1llus mentioned this pull request Jun 1, 2023
Closed
@P1llus P1llus merged commit ce31141 into elastic:main Jun 1, 2023
@elasticmachine
Copy link

Package cisco_asa - 2.17.1 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

@elasticmachine
Copy link

Package cisco_ftd - 2.12.1 containing this change is available at https://epr.elastic.co/search?package=cisco_ftd

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@LaZyDK @sodhikirti07
[cisco_asa,cisco_ftd] Fix VPN event.action (#6423)
c9ede83 
* Initial commit

* Bump pull id

* Initial commit

* Bump pull id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
Integration:cisco_asa Cisco ASA Integration:cisco_ftd Cisco FTD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LaZyDK @P1llus @elasticmachine @andrewkroh