-
Notifications
You must be signed in to change notification settings - Fork 474
[AWS] Add include_linked_accounts parameter for all metrics data streams #6459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kaiyan-sheng
merged 7 commits into
elastic:main
from
kaiyan-sheng:add_include_linked_accounts
Jun 9, 2023
Merged
[AWS] Add include_linked_accounts parameter for all metrics data streams #6459
kaiyan-sheng
merged 7 commits into
elastic:main
from
kaiyan-sheng:add_include_linked_accounts
Jun 9, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌐 Coverage report
|
zmoog
reviewed
Jun 5, 2023
tommyers-elastic
approved these changes
Jun 9, 2023
zmoog
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
Package aws - 1.43.0 containing this change is available at https://epr.elastic.co/search?package=aws |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to add
include_linked_accounts
config parameter into all metrics data streams. This parameter is added into Metricbeat in elastic/beats#35648.Checklist
changelog.yml
file.Screenshots
Default looks like this:

Config Include Linked Accounts is default to false for now.
With the Include Linked Accounts toggle enabled, the agent policy looks like this:
I tested it with the config above and it does collect metrics from both monitoring account and linked source account:
