Skip to content

[AWS] Add link to the main requirements section in all AWS integrations #6480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2023
Merged

[AWS] Add link to the main requirements section in all AWS integrations #6480

merged 2 commits into from
Jun 5, 2023

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Jun 5, 2023 •
edited
Loading

What does this PR do?

Replace the plain text "AWS integration requirements" with an actual link to the requirements section.

Why?

The text is good, but hyperlinks are even better.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

image

@zmoog
Add link to the AWS integration requirements
95c0ad8 
Replace the plain text with an actual link to the requirements.
@zmoog zmoog self-assigned this Jun 5, 2023
@zmoog zmoog added Team:Cloud-Monitoring Label for the Cloud Monitoring team documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. labels Jun 5, 2023
@zmoog zmoog marked this pull request as ready for review June 5, 2023 21:38
@zmoog zmoog requested a review from a team as a code owner June 5, 2023 21:38
@zmoog zmoog changed the title Add link to the AWS integration requirements [AWS] Add link to the main requirements section in all AWS integrations Jun 5, 2023
@elasticmachine
Copy link

elasticmachine commented Jun 5, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-05T21:38:17.684+0000

  • Duration: 51 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 190
Skipped 4
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👍 25.75
Classes 93.75% (15/16) 👍 25.75
Methods 85.921% (238/277) 👍 5.405
Lines 85.925% (7387/8597) 👍 3.057
Conditionals 100.0% (0/0) 💚

@zmoog zmoog merged commit b7d3f0c into elastic:main Jun 5, 2023
@zmoog zmoog deleted the zmoog/link-to-aws-requirements branch June 5, 2023 23:02
@elasticmachine
Copy link

Package aws - 1.40.1 containing this change is available at https://epr.elastic.co/search?package=aws

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@zmoog @sodhikirti07
[AWS] Add link to the main requirements section in all AWS integratio…
ce20fa6 
…ns (#6480)

* Add link to the AWS integration requirements

Replace the plain text with an actual link to the requirements.

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@zmoog zmoog

Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zmoog @elasticmachine @kaiyan-sheng @andrewkroh