Skip to content

[AWS] [API Gateway] Logs data stream #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 20, 2023

Conversation

lucian-ioan
Copy link
Contributor

@lucian-ioan lucian-ioan commented Jun 10, 2023

What does this PR do?

Adds logs data stream which collects API Gateway logs from CloudWatch or S3.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@lucian-ioan lucian-ioan self-assigned this Jun 10, 2023
@lucian-ioan lucian-ioan mentioned this pull request Jun 10, 2023
8 tasks
@elasticmachine
Copy link

elasticmachine commented Jun 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-20T10:50:57.477+0000

  • Duration: 54 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 198
Skipped 4
Total 202

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (16/16) 💚
Files 94.118% (16/17) 👎 -3.116
Classes 94.118% (16/17) 👎 -3.116
Methods 85.862% (249/290) 👎 -6.31
Lines 86.001% (7464/8679) 👎 -5.149
Conditionals 100.0% (0/0) 💚

@lucian-ioan lucian-ioan marked this pull request as ready for review July 4, 2023 06:23
@lucian-ioan lucian-ioan requested a review from a team as a code owner July 4, 2023 06:23
@tdancheva
Copy link
Contributor

Since @zmoog already picked it up, I will just leave a comment, can you please add a standalone S3 bucket option, like I have done here? You can see this issue. We need to do this for all the data streams where it is missing. I did it for and merged Cloudtrail and vpcflow so far.

@lucian-ioan lucian-ioan requested a review from zmoog July 19, 2023 16:04
description: The maximum duration of AWS API can take. The maximum is half of the visibility timeout value.
- name: queue_url
type: text
title: Queue URL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a leftover, I noticed we have two "Queue URL" fields:

image

@lucian-ioan lucian-ioan requested a review from zmoog July 20, 2023 09:11
@zmoog
Copy link
Contributor

zmoog commented Jul 20, 2023

The PR looks good. I missed only one small thing in the last pass: an SQS option at the end of the advanced setting instead of close to the other SQS options.

CleanShot 2023-07-20 at 11 35 20@2x

Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only move the SQS option with the others and then LGTM.

@lucian-ioan lucian-ioan merged commit 72d1474 into elastic:main Jul 20, 2023
@elasticmachine
Copy link

Package aws - 1.49.0 containing this change is available at https://epr.elastic.co/search?package=aws

@lucian-ioan lucian-ioan linked an issue Jul 24, 2023 that may be closed by this pull request
8 tasks
@lucian-ioan lucian-ioan deleted the add_apigateway_logs branch February 6, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS] [API Gateway] Logs data stream AWS API Gateway Integration
5 participants