-
Notifications
You must be signed in to change notification settings - Fork 474
Added support for processors for all oracle integrations #6537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for processors for all oracle integrations #6537
Conversation
I call for a discussion to determine the impact of this change and TSDB enablement as Oracle package is an immediate candidate for TSDB enablement. How to ensure that the fields marked as dimensions are not removed? I read that |
You can use the processors on the logs side of things in majority of all packages. You can use it to add fields, that are not possible otherwise. It's a weird situation that one integration allows the configuration of the processors and another one does not. Assume you are a customer and you want to add a set of field to every integration, since you rely on that field to determine security, e.g. document level security. You cannot do this centrally in an ingest pipeline, since you don't know where the data came from. The best possibility is to do this on the agent itself and therefore the integration to append an add fields processor and add your department, or whatever you want. Thus allowing you to enrich the data when collected. |
💔 Build Failed
Failed CI Steps |
🌐 Coverage report
|
@agithomas can you review again? Not really sure what I am supposed to do to resolve the conflicts. |
Agi, this is a common functionality across integrations. Having a provision to specify processors for data enrichment. |
@philippkahr : Changes look good. Please fix the. conflicts and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Please resolve the conflicts and merge.
Package oracle - 1.20.0 containing this change is available at https://epr.elastic.co/search?package=oracle |
What does this PR do?
Adds support for the processors on all oracle integrations
Checklist
changelog.yml
file.