Skip to content

[Apache Tomcat] Add integration package with connection pool data stream #6596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 25, 2023
Merged

[Apache Tomcat] Add integration package with connection pool data stream #6596

merged 11 commits into from
Jul 25, 2023

Conversation

kush-elastic
Copy link
Contributor

@kush-elastic kush-elastic commented Jun 16, 2023 •
edited
Loading

Urgency

  • Normal

Activity Type

  • Enhancement

What does this PR do?

  • Added 1 data stream (Connection pool metrics).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • Verify if field mapping is correct in the data stream template.
  • Verification of data in visualisation after enabling TSDB flag in kibana
  • Verification of the count of documents (before & after TSDB enablement) in Discover Interface

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/apache_tomcat) directory.
  • Run the following command to run tests. elastic-package test

Screenshots

apache_tomcat-connection-pool-dashboard

Meta issue

Related Issue

Related PRs

@kush-elastic kush-elastic self-assigned this Jun 16, 2023
@kush-elastic kush-elastic marked this pull request as ready for review June 16, 2023 14:01
@kush-elastic kush-elastic requested a review from a team as a code owner June 16, 2023 14:01
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @kush-elastic

@elasticmachine
Copy link

elasticmachine commented Jun 16, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-25T05:45:25.457+0000

  • Duration: 25 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 52
Skipped 0
Total 52

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 16, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (9/9) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 95.062% (77/81) 👍 9.347
Lines 79.846% (931/1166) 👎 -14.716
Conditionals 100.0% (0/0) 💚

milan-elastic
milan-elastic approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harnish-crest-data harnish-crest-data mentioned this pull request Jun 19, 2023
Merged
7 tasks
@kush-elastic kush-elastic linked an issue Jun 20, 2023 that may be closed by this pull request
[Apache Tomcat] Add ConnectionPool Metrics datastream #6389
Closed
13 tasks
@muthu-mps muthu-mps self-requested a review June 27, 2023 06:58
This was referenced Jun 29, 2023
Closed
Merged
@kush-elastic kush-elastic mentioned this pull request Jul 3, 2023
Closed
13 tasks
This was referenced Jul 3, 2023
Merged
Closed
Closed
muthu-mps
muthu-mps reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agithomas - Please review changes from TSDB perspective. Otherwise the changes looks good!

@kush-elastic
update processor description as per review comment
fd8553b
@kush-elastic
Merge branch 'main' of https://github.com/kush-elastic/integrations i…
55a788f 
…nto package_apache_tomcat_connection_pool

Conflicts:
	packages/apache_tomcat/_dev/build/docs/README.md
	packages/apache_tomcat/changelog.yml
	packages/apache_tomcat/docs/README.md
	packages/apache_tomcat/manifest.yml
@kush-elastic
address review comments to update ecs.yml as per tsdb enablement
50d62c3
@kush-elastic
move index_mode lines to end of the file as per review comment
72fbc53
@kush-elastic
Merge branch 'main' of https://github.com/kush-elastic/integrations i…
f90291a 
…nto package_apache_tomcat_connection_pool

Conflicts:
	packages/apache_tomcat/changelog.yml
@harnish-crest-data harnish-crest-data mentioned this pull request Jul 17, 2023
Merged
4 tasks
agithomas
agithomas reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from TSDB side of things.

@muthu-mps
Copy link
Contributor

@kush-elastic - The dashboard displays only the active and idle connections but the data stream captures a lot of fields. Could you see the potential to add more metrics to the dashboard? @SubhrataK - Please look at the dashboard changes.

@kush-elastic
Copy link
Contributor Author

@kush-elastic - The dashboard displays only the active and idle connections but the data stream captures a lot of fields. Could you see the potential to add more metrics to the dashboard? @SubhrataK - Please look at the dashboard changes.

I see most of the fields are boolean. And for the rest of the fields, based on the discussion with the Subhrata, We don't have metrics that we can display as a part of the visualization. There is an application count already present in the Overview dashboard itself. Let me know your suggestions that we can add as visualizations!

@muthu-mps muthu-mps self-requested a review July 24, 2023 11:03
muthu-mps
muthu-mps approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic
Merge branch 'main' of https://github.com/kush-elastic/integrations i…
ddeca87 
…nto package_apache_tomcat_connection_pool

Conflicts:
	packages/apache_tomcat/_dev/build/docs/README.md
	packages/apache_tomcat/changelog.yml
	packages/apache_tomcat/docs/README.md
	packages/apache_tomcat/manifest.yml
@kush-elastic kush-elastic merged commit 36df440 into elastic:main Jul 25, 2023
@elasticmachine
Copy link

Package apache_tomcat - 0.11.0 containing this change is available at https://epr.elastic.co/search?package=apache_tomcat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas left review comments

@muthu-mps muthu-mps muthu-mps approved these changes

@milan-elastic milan-elastic milan-elastic approved these changes

Assignees

@kush-elastic kush-elastic

Labels
Integration:apache_tomcat Apache Tomcat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Apache Tomcat] Add ConnectionPool Metrics datastream
6 participants
@kush-elastic @elasticmachine @muthu-mps @agithomas @milan-elastic @andrewkroh