Skip to content

[cisco_ftd] Remove Invalid ID #6669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 7, 2023
Merged

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Jun 22, 2023

What does this PR do?

Removal of the value Invalid ID

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@LaZyDK LaZyDK requested a review from a team as a code owner June 22, 2023 11:23
@elasticmachine
Copy link

elasticmachine commented Jun 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-06T09:02:18.467+0000

  • Duration: 18 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Jun 22, 2023

Is there a particular problem that this solves?

…ne/default.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@LaZyDK
Copy link
Contributor Author

LaZyDK commented Jun 23, 2023

It just removes a string that has no value. I intended to have this work when I initially did the PR, but missed a field.

@efd6
Copy link
Contributor

efd6 commented Jun 29, 2023

/test

@efd6
Copy link
Contributor

efd6 commented Jun 29, 2023

Need to run elastic-package build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (22/22) 💚 19.048
Lines 70.724% (1406/1988) 👎 -20.504
Conditionals 100.0% (0/0) 💚

@LaZyDK
Copy link
Contributor Author

LaZyDK commented Jul 6, 2023

That's better.

@efd6 efd6 merged commit bbfe7d9 into elastic:main Jul 7, 2023
@elasticmachine
Copy link

Package cisco_ftd - 2.13.1 containing this change is available at https://epr.elastic.co/search?package=cisco_ftd

@LaZyDK LaZyDK deleted the ftd-remove-invalid-id-fix branch July 7, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants