-
Notifications
You must be signed in to change notification settings - Fork 474
[System] rework metric dashboards #6743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Let's keep this open! |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Keep this open |
…pdate-system-overview-dashboards
🌐 Coverage report
|
…m/elastic/integrations into update-system-overview-dashboards
packages/system/changelog.yml
Outdated
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "1.41.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if this warrants a bump to 2.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to change this (not sure what the criteria are for a major bump).
FWIW, I will be submitting a second PR to finish converting all the visualizations in the package to Lens. Does that change anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great, thanks! without reviewing the reams of JSON and just looking at the screenshots, this gets a +1 from me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the one thing that worries me is the Load
metric. This is only available on non-Windows OSes, so Windows users just get a blank UI item. However, I'm not sure we have the capability to just say "remove the visualization if there's no data," hence why I'm approving this. If we can do that and no one told me, we definitely should.
We don't have that capability. It's an interesting feature request. I think our answer today is: create two dashboards. But, that doesn't always make sense (this case for example) so I'm going to raise this with the team to see if we are tracking an issue. |
packages/system/kibana/dashboard/system-79ffd6e0-faa0-11e6-947f-177f697178b8.json
Outdated
Show resolved
Hide resolved
…pdate-system-overview-dashboards
packages/system/kibana/dashboard/system-79ffd6e0-faa0-11e6-947f-177f697178b8.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
5dbe535
to
7cb2edf
Compare
The screenshots I added here are quite large. Do we have any guidelines on screenshot size? cc @efd6 @muthu-mps |
Package system - 1.42.0 containing this change is available at https://epr.elastic.co/search?package=system |
What does this PR do?
Reworks the metric system overview and host overview dashboards to use Lens.
Also leverages Lens features to represent current system state more reliably and clearly (especially, uses Lens Last value function instead of TSVB "Last value" mode to resolve #1437).
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots
Overview
Before
After
Host overview
Before
After