Skip to content

[MySql] Fix to correct the aggregate function used in dashboard #6828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

agithomas
Copy link
Contributor

  • Bug

What does this PR do?

The dashboard uses avg function on field having metric_type value counter. This is not a supported feature. The PR updates to use the max() function instead.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Dashboard testing

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jul 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-05T17:48:47.071+0000

  • Duration: 22 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 63
Skipped 0
Total 63

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 92.857% (26/28) 👍
Lines 94.34% (150/159) 👍
Conditionals 100.0% (0/0) 💚

@agithomas agithomas mentioned this pull request Jul 6, 2023
19 tasks
@agithomas agithomas marked this pull request as ready for review July 6, 2023 08:21
@agithomas agithomas requested a review from a team as a code owner July 6, 2023 08:21
@ritalwar ritalwar changed the title Fix to correct the aggregate function used in dashboard [MySql] Fix to correct the aggregate function used in dashboard Jul 6, 2023
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor Author

image

@agithomas agithomas merged commit bff23a2 into elastic:main Jul 6, 2023
@elasticmachine
Copy link

Package mysql - 1.12.4 containing this change is available at https://epr.elastic.co/search?package=mysql

@agithomas agithomas deleted the issue-5277-mysql-dashboard-counter-fix branch February 12, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants