Skip to content

aws_logs package: allow reroute to logs-*-* #6841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

gsantoro
Copy link
Contributor

@gsantoro gsantoro commented Jul 6, 2023

What does this PR do?

Add permissions to write to logs--. Same changes as in this issue elastic/kibana#157897.

# Ensures agents have permissions to write data to `logs-*-*`
elasticsearch:
  dynamic_dataset: true
  dynamic_namespace: true

Similar change was applied to aws package and then reverted at #6806. That was the wrong package to modify.

This package aws_log is instead the right one, since it should reroute the traffic from AWS logs in cloudwatch

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gsantoro gsantoro requested a review from a team as a code owner July 6, 2023 11:48
@gsantoro gsantoro requested review from ruflin and felixbarny July 6, 2023 11:48
@gsantoro gsantoro self-assigned this Jul 6, 2023
@gsantoro gsantoro added enhancement New feature or request v8.9.0 labels Jul 6, 2023
@elasticmachine
Copy link

elasticmachine commented Jul 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-06T11:50:42.794+0000

  • Duration: 13 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (2/3) 👎 -29.167
Lines 100.0% (0/0) 💚 14.679
Conditionals 100.0% (0/0) 💚

@gsantoro gsantoro merged commit 813c1f7 into elastic:main Jul 6, 2023
@gsantoro gsantoro deleted the feature/aws_log_dynamic_dataset branch July 6, 2023 15:09
@elasticmachine
Copy link

Package aws_logs - 0.5.0 containing this change is available at https://epr.elastic.co/search?package=aws_logs

@andrewkroh andrewkroh added the Integration:aws_logs Custom AWS Logs label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:aws_logs Custom AWS Logs v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants