system: improve event.{action,category,outcome} enrichment for auth datastream #6966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
efd6
commented
Jul 17, 2023
Comment on lines
+89
to
+96
| - set: | ||
| field: event.action | ||
| value: 'logged-on' | ||
| if: ctx.message != null && ctx.message.contains('session opened') | ||
| - set: | ||
| field: event.action | ||
| value: 'logged-off' | ||
| if: ctx.message != null && ctx.message.contains('session closed') |
There was a problem hiding this comment.
ISTM that these should be "session-opened" and "session-closed" since this is not a login, but if these are the terms that are used in the security solution they are OK as is.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
lalit-satapathy
approved these changes
Jul 18, 2023
|
Package system - 1.37.0 containing this change is available at https://epr.elastic.co/search?package=system |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enriches event fields for pam session and auth messages and for process-related auth messages.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots