Skip to content

[prometheus] Ensure event.kind is correctly set for pipeline errors #7082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 29, 2023
Merged

[prometheus] Ensure event.kind is correctly set for pipeline errors #7082

merged 6 commits into from
Sep 29, 2023

Conversation

MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Jul 20, 2023

What does this PR do?

Modify prometheus integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish requested a review from a team as a code owner July 20, 2023 18:09
@MakoWish MakoWish requested review from gizas and constanca-m July 20, 2023 18:09
@elasticmachine
Copy link

elasticmachine commented Jul 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-28T16:20:08.810+0000

  • Duration: 16 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@gizas gizas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM checking other relevant PRs

@MakoWish
Copy link
Contributor Author

This one is failing for invalid types in ./data_stream/collector/fields/fields.yml and /data_stream/query/fields/fields.yml, but those changes were not pushed by me, and I am not exactly sure how to correct those. According to the error, the type: object is not valid.

@elasticmachine
Copy link

elasticmachine commented Aug 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (8/12)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@botelastic
Copy link

botelastic bot commented Sep 10, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Sep 10, 2023
@botelastic botelastic bot removed the Stalled label Sep 28, 2023
@MakoWish
Copy link
Contributor Author

Had to fix some conflicts. Would someone mind kicking off another /test and merging if/when done? I don't have permissions to.

@constanca-m
Copy link
Contributor

Done @MakoWish

@constanca-m constanca-m merged commit c177004 into elastic:main Sep 29, 2023
@elasticmachine
Copy link

Package prometheus - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=prometheus

@MakoWish MakoWish deleted the 6582-prometheus branch September 29, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants