Skip to content

[windows] Add Windows AppLocker Data Stream (MSI and Script) #7279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 10, 2023
Merged

[windows] Add Windows AppLocker Data Stream (MSI and Script) #7279

merged 19 commits into from
Aug 10, 2023

Conversation

nicpenning
Copy link
Contributor

@nicpenning nicpenning commented Aug 5, 2023

  • Enhancement

What does this PR do?

This PR adds the Windows AppLocker MSI and Script data stream which allows the ingestion of those events from the Windows Event Log. This also updates the dashboard with a better title and adds 4 new visualizations to explore the data.

Resolves Part of - #6979

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

image

@nicpenning nicpenning requested review from a team as code owners August 5, 2023 09:52
@elasticmachine
Copy link

elasticmachine commented Aug 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-10T00:52:44.584+0000

  • Duration: 18 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 140
Skipped 0
Total 140

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@nicpenning
Copy link
Contributor Author

/test

1 similar comment
@andrewkroh
Copy link
Member

/test

@elasticmachine
Copy link

elasticmachine commented Aug 9, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 90.0% (9/10) 👎 -10.0
Classes 90.0% (9/10) 👎 -10.0
Methods 84.545% (93/110) 👎 -15.455
Lines 92.65% (5458/5891) 👍 0.624
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide screen shots showing the dashboard changes.

Also, please make the following change to CODEOWNERS

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index ddcfae883..aacc76f5a 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -243,6 +243,7 @@
 /packages/websphere_application_server @elastic/obs-infraobs-integrations
 /packages/windows @elastic/elastic-agent-data-plane @elastic/security-external-integrations
 /packages/windows/data_stream/applocker_exe_and_dll @elastic/security-external-integrations
+/packages/windows/data_stream/applocker_msi_and_script @elastic/security-external-integrations
 /packages/windows/data_stream/forwarded @elastic/security-external-integrations
 /packages/windows/data_stream/perfmon @elastic/elastic-agent-data-plane
 /packages/windows/data_stream/powershell @elastic/security-external-integrations

@efd6
Copy link
Contributor

efd6 commented Aug 9, 2023

/test

@nicpenning
Copy link
Contributor Author

Can you provide screen shots showing the dashboard changes.

Also, please make the following change to CODEOWNERS

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index ddcfae883..aacc76f5a 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -243,6 +243,7 @@
 /packages/websphere_application_server @elastic/obs-infraobs-integrations
 /packages/windows @elastic/elastic-agent-data-plane @elastic/security-external-integrations
 /packages/windows/data_stream/applocker_exe_and_dll @elastic/security-external-integrations
+/packages/windows/data_stream/applocker_msi_and_script @elastic/security-external-integrations
 /packages/windows/data_stream/forwarded @elastic/security-external-integrations
 /packages/windows/data_stream/perfmon @elastic/elastic-agent-data-plane
 /packages/windows/data_stream/powershell @elastic/security-external-integrations

Do you mean update the .png in the package or add those screenshots to this PR for review?

@nicpenning
Copy link
Contributor Author

I added these:
image

And removed the "-" in the title of the dashboard between [Windows Applocker] - Audited Blocked Applications
image

@efd6
Copy link
Contributor

efd6 commented Aug 10, 2023

/test

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 4c465f2 into elastic:main Aug 10, 2023
@nicpenning nicpenning deleted the applocker_msi_and_script branch August 10, 2023 01:45
@elasticmachine
Copy link

Package windows - 1.30.0 containing this change is available at https://epr.elastic.co/search?package=windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants