Skip to content

Add check for empty fields in azure integration #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 2, 2021
Merged

Add check for empty fields in azure integration #741

merged 5 commits into from
Mar 2, 2021

Conversation

narph
Copy link
Contributor

@narph narph commented Feb 23, 2021

What does this PR do?

Adds check for empty fields in azure integration

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

@narph narph self-assigned this Feb 23, 2021
@narph narph added Integration:azure Azure Logs Team:Integrations Label for the Integrations team labels Feb 23, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

elasticmachine commented Feb 23, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #741 updated

  • Start Time: 2021-03-02T09:58:43.516+0000

  • Duration: 13 min 30 sec

  • Commit: 004d14f

Test stats 🧪

Test Results
Failed 0
Passed 39
Skipped 0
Total 39

Trends 🧪

Image of Build Times

Image of Tests

@mtojek mtojek self-requested a review February 24, 2021 09:43
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing due to this: elastic/beats#24198 . If it's not an urgent issue I would wait for the correct Docker images.

Apart from this, LGTM

BTW we have introduced a Terraform service deployer that should also support Azure (if only our CI does/has secrets). You can schedule some time in the future to research this area and create a couple of tests.

@mtojek
Copy link
Contributor

mtojek commented Feb 25, 2021

I think you can rebase it against master now.

@narph narph requested a review from mtojek March 2, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:azure Azure Logs Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants