-
Notifications
You must be signed in to change notification settings - Fork 474
[Azure] Fix the metrics field name in the container instance datastream #7445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure] Fix the metrics field name in the container instance datastream #7445
Conversation
The processor now renames the actual field name `azure.metrics` produced by the Metricbeat metricset, according to the current configuration
Since there may be users with deployments of this integration, we add an alias for all the `azure.metrics.*` fields pointing to the equivalent `azure.container_instace.*` field. Existing users that are using the `azure.metrics` can take advantage of new documents created with the `azure.container_instace.*` names.
🌐 Coverage report
|
The sample document with the `azure.monitor.*` field comes from a Metricbeat. Azure Monitor field names can vary depending on the metricset configuration. See https://github.com/elastic/beats/blob/90cd631cabf82c2bac7999029feb791764ba2698/x-pack/metricbeat/module/azure/data.go#L100-L106 for more information about how this works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog and manifest version update are missing, could you please add it?
maybe it makes sense to update the relevant dashboards with the correct metric naming? for example: If I install fixed version of integration, it might be confusing to find that used azure.metrics...
instead of expected azure.container_instance
, @zmoog wdyt?
🤦 I added the missing changelog entry, thanks!
The dashboards was already using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add aliases to allow existing users to access all data with the old field names azure.metrics.* for backwards compatibility.
🤩
If you break it, you fix it ™ |
Package azure_metrics - 1.0.24 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
What does this PR do?
Fix the rename processor to use the correct field name. Add aliases to allow existing users to access all data with the old field names
azure.metrics.*
for backwards compatibility.Checklist
changelog.yml
file.Author's Checklist
azure.metrics.*
field namesHow to test this PR locally
Aliases for backwards compatibility
Existing users can use field names
azure.metrics.*
in dashboards and queries to access old and new documents:In the
metrics-azure.container_instance-default
there are:12
documents created with integration v1.0.23, havingazure.metrics
fields only.22
documents created with integration v1.0.24, havingazure.container_instance
fields only.If we query
azure.container_instance
we get the 22 new docs only. However, if we query usingazure.metrics
we get all 34 (12 + 22) documents.Related issues
Screenshots
The dashboard can show data now that the pipeline creates the documents with the expected field names.