[azure_frontdoor] Fix Azure frontdoor preserve original event #7464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
nicpenning
changed the title
|
/test |
🌐 Coverage report
|
efd6
reviewed
Aug 21, 2023
|
|
||
| on_failure: | ||
| - set: | ||
| field: event.kind | ||
| value: pipeline_error | ||
| - append: | ||
| field: error.message | ||
| value: '{{{ _ingest.on_failure_message }}}' | ||
| value: '{{{ _ingest.on_failure_message }}}' |
There was a problem hiding this comment.
Suggested change
| value: '{{{ _ingest.on_failure_message }}}' | |
| value: '{{{ _ingest.on_failure_message }}}' |
(this fixes the missing trailing new line in the file)
There was a problem hiding this comment.
Doesn't look like a change is able to be applied above.
packages/azure_frontdoor/data_stream/access/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/azure_frontdoor/data_stream/waf/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/azure_frontdoor/data_stream/waf/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
|
@efd6 👋 |
|
/test |
efd6
reviewed
Aug 31, 2023
packages/azure_frontdoor/data_stream/waf/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/azure_frontdoor/data_stream/access/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
…pipeline/default.yml Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
|
Checking in here. Anything needed here to review? |
|
Updated, as this got stale. Can someone please review? |
…st_pipeline/default.yml Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
|
I think I resolved the issues you addressed. |
|
/test |
|
Package azure_frontdoor - 1.5.1 containing this change is available at https://epr.elastic.co/search?package=azure_frontdoor |
andrewkroh
added
the
Integration:azure_frontdoor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the "Preserve Original Event" feature for both Frontdoor Access and WAF data streams which has been stated here:
#6847
#6848
Checklist
changelog.ymlfile.