Skip to content

[Azure] [monitor] Add dimension and metric_type metadata to the monitor datastream #7473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

tetianakravchenko
Copy link
Contributor

What does this PR do?

Add dimension and metric_type metadata to the monitor datastream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner August 21, 2023 12:44
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Aug 21, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-29T10:57:25.044+0000

  • Duration: 15 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 21, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 73.333% (22/30) 👎 -11.494
Lines 100.0% (21/21) 💚 3.946
Conditionals 100.0% (0/0) 💚

@tetianakravchenko tetianakravchenko changed the title [Azure] [monitore] Add dimension and metric_type metadata to the monitor datastream [Azure] [monitor] Add dimension and metric_type metadata to the monitor datastream Aug 21, 2023
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding event.kind: pipeline_error in case of pipeline failure, I see this behavior adopted more and more.

We should consider using error.message as an array, as it has become increasingly common but optional.

Comment on lines 8 to 11
on_failure:
- set:
field: error.message
value: '{{ _ingest.on_failure_message }}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about also setting event.kind?

Here's an example of the current trend: https://github.com/elastic/integrations/pull/7043/files#diff-ff596a529bb3558054ae525d4e233a54a30963b2ac998fc37eeaa1ed29d66474

Suggested change
on_failure:
- set:
field: error.message
value: '{{ _ingest.on_failure_message }}'
on_failure:
- set:
field: event.kind
value: pipeline_error
- set:
field: error.message
value: '{{ _ingest.on_failure_message }}'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - 2216ad9,

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko merged commit e193098 into elastic:main Aug 30, 2023
@tetianakravchenko tetianakravchenko deleted the azure_monitor_tsdb branch August 30, 2023 13:22
@elasticmachine
Copy link

Package azure_metrics - 1.0.34 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

@andrewkroh andrewkroh added the Integration:azure_metrics Azure Resource Metrics label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:azure_metrics Azure Resource Metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants