-
Notifications
You must be signed in to change notification settings - Fork 474
[Azure] [monitor] Add dimension and metric_type metadata to the monitor datastream #7473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure] [monitor] Add dimension and metric_type metadata to the monitor datastream #7473
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding event.kind: pipeline_error
in case of pipeline failure, I see this behavior adopted more and more.
We should consider using error.message
as an array, as it has become increasingly common but optional.
on_failure: | ||
- set: | ||
field: error.message | ||
value: '{{ _ingest.on_failure_message }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about also setting event.kind
?
Here's an example of the current trend: https://github.com/elastic/integrations/pull/7043/files#diff-ff596a529bb3558054ae525d4e233a54a30963b2ac998fc37eeaa1ed29d66474
on_failure: | |
- set: | |
field: error.message | |
value: '{{ _ingest.on_failure_message }}' | |
on_failure: | |
- set: | |
field: event.kind | |
value: pipeline_error | |
- set: | |
field: error.message | |
value: '{{ _ingest.on_failure_message }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done - 2216ad9,
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Package azure_metrics - 1.0.34 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
What does this PR do?
Add dimension and metric_type metadata to the monitor datastream
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots