[O11y][PHP-FPM] Add service.address field and update dashboard #7523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harnish-crest-data
added
enhancement
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
ishleenk17
reviewed
Aug 30, 2023
| - add_fields: | ||
| target: service | ||
| fields: | ||
| address: {{hostname}} |
There was a problem hiding this comment.
Why is this processor explicitly required here?
There was a problem hiding this comment.
@ishleenk17 The data stream uses the httpjson filebeat input in the backend. However, the httpjson filebeat input doesn't generate the service.address field automatically that actually useful for users to filter out the details of the host. Hence we need to explicitly add this processor!
…into php-fpm-support-service-address-field Conflicts: packages/php_fpm/changelog.yml packages/php_fpm/data_stream/pool/fields/ecs.yml packages/php_fpm/data_stream/process/fields/ecs.yml packages/php_fpm/manifest.yml
|
Package php_fpm - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=php_fpm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
changelog.ymlfile.Related issues