Skip to content

[Prometheus] [remote_write] Enable tsdb on remote_write datastream #7598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tetianakravchenko
Copy link
Contributor

What does this PR do?

Enable tsdb on remote_write datastream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Tested with https://github.com/elastic/TSDB-migration-test-kit:

Index being used for the settings and mappings is .ds-metrics-prometheus.remote_write-default-2023.08.29-000002.

The time series fields for the TSDB index are: 
        - dimension (9 fields):
                - agent.id
                - cloud.account.id
                - cloud.availability_zone
                - cloud.instance.id
                - cloud.provider
                - cloud.region
                - container.id
                - host.name
                - prometheus.labels_fingerprint
        ...
        - routing_path (9 fields):
                - agent.id
                - cloud.account.id
                - cloud.availability_zone
                - cloud.instance.id
                - cloud.provider
                - cloud.region
                - container.id
                - host.name
                - prometheus.labels_fingerprint

Index tsdb-index-enabled successfully created.

Copying documents from .ds-metrics-prometheus.remote_write-default-2023.08.29-000001 to tsdb-index-enabled...
All 50000 documents taken from index .ds-metrics-prometheus.remote_write-default-2023.08.29-000001 were successfully placed to index tsdb-index-enabled.

Related issues

Screenshots

[Metrics Prometheus] Prometheus Server overview dashboard works as expected after enabling tsdb:
Screenshot 2023-08-29 at 19 20 35
Screenshot 2023-08-29 at 19 20 47

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner August 29, 2023 17:21
@elasticmachine
Copy link

elasticmachine commented Aug 29, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-30T08:54:34.205+0000

  • Duration: 15 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 29, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (8/12) 👍
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@tetianakravchenko tetianakravchenko merged commit 719fd67 into elastic:main Aug 31, 2023
@tetianakravchenko tetianakravchenko deleted the prometheus_remote_write_enable_tsdb branch August 31, 2023 11:21
@elasticmachine
Copy link

Package prometheus - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=prometheus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants