Skip to content

[Olly] [AWS] Update Billing Overview dashboard #7659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

milan-elastic
Copy link
Contributor

@milan-elastic milan-elastic commented Sep 5, 2023

  • Bug

What does this PR do?

  • Update visualization aggregation from sum to last_value
  • Currently, all visualization has sum aggregation which was leading to this issue

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Before changes using sum aggregation with 12h period of time

image

After changes using last_value aggregation with 12h period of time

image

@milan-elastic milan-elastic added Integration:aws AWS bugfix Pull request that fixes a bug issue labels Sep 5, 2023
@milan-elastic milan-elastic self-assigned this Sep 5, 2023
@milan-elastic milan-elastic requested review from a team as code owners September 5, 2023 05:56
@elasticmachine
Copy link

elasticmachine commented Sep 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-05T06:15:03.401+0000

  • Duration: 55 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 212
Skipped 3
Total 215

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 5, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -5.556
Classes 94.444% (17/18) 👎 -5.556
Methods 86.047% (259/301) 👎 -13.953
Lines 86.075% (7566/8790) 👎 -9.621
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor

@milan-elastic , please enable all items in the checklist in the description.

@agithomas
Copy link
Contributor

As the change is related to a bug, please elaborate on what is the issue for which the fix is applied in the changelog.

@milan-elastic
Copy link
Contributor Author

As the change is related to a bug, please elaborate on what is the issue for which the fix is applied in the changelog.

Done

milan-elastic and others added 2 commits September 15, 2023 18:51
Co-authored-by: Agi K Thomas <101976829+agithomas@users.noreply.github.com>
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comments added.

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like the right fix 👍

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milan-elastic milan-elastic merged commit ab65107 into elastic:main Oct 5, 2023
@elasticmachine
Copy link

Package aws - 2.8.1 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:aws AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants