Skip to content

[awsfirehose] Add support for routing api gateway logs #7701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Sep 7, 2023

What does this PR do?

This PR adds routing rules for API gateway access logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review September 7, 2023 14:41
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner September 7, 2023 14:41
@kaiyan-sheng kaiyan-sheng self-assigned this Sep 7, 2023
@kaiyan-sheng kaiyan-sheng added the Integration:awsfirehose Amazon Data Firehose label Sep 7, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-12T14:40:51.290+0000

  • Duration: 14 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 60.0% (3/5) 👎 -40.0
Lines 100.0% (79/79) 💚 0.82
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would add a comment to give our future selves why the big if is there.

@kaiyan-sheng kaiyan-sheng requested a review from zmoog September 12, 2023 14:42
Copy link
Contributor

@lucian-ioan lucian-ioan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng merged commit 4e9185a into elastic:main Sep 14, 2023
@kaiyan-sheng kaiyan-sheng deleted the api_gateway branch September 14, 2023 12:58
@elasticmachine
Copy link

Package awsfirehose - 0.2.0 containing this change is available at https://epr.elastic.co/search?package=awsfirehose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:awsfirehose Amazon Data Firehose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants