Skip to content

[O11y][Couchbase] Remove forwarded tag from metrics data streams #7825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2023
Merged

[O11y][Couchbase] Remove forwarded tag from metrics data streams #7825

merged 4 commits into from
Oct 9, 2023

Conversation

harnish-crest-data
Copy link
Contributor

  • Bug

What does this PR do?

  • This PR removes the forwarded tag from the metricbeat-based data streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@harnish-crest-data harnish-crest-data added Integration:couchbase Couchbase bugfix Pull request that fixes a bug issue labels Sep 14, 2023
@harnish-crest-data harnish-crest-data self-assigned this Sep 14, 2023
@harnish-crest-data harnish-crest-data marked this pull request as ready for review September 14, 2023 12:58
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner September 14, 2023 12:58
@harnish-crest-data harnish-crest-data mentioned this pull request Sep 14, 2023
Closed
7 tasks
@elasticmachine
Copy link

elasticmachine commented Sep 14, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-09T06:40:13.219+0000

  • Duration: 26 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 45
Skipped 0
Total 45

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 14, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 100.0% (10/10) 💚 3.325
Classes 100.0% (10/10) 💚 3.325
Methods 100.0% (72/72) 💚 7.667
Lines 100.0% (1076/1076) 💚 11.573
Conditionals 100.0% (0/0) 💚

ali786XI
ali786XI approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ishleenk17
ishleenk17 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@harnish-crest-data
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
ec6459c 
…into couchbase-remove-forwarded-tag

Conflicts:
	packages/couchbase/changelog.yml
	packages/couchbase/manifest.yml
@harnish-crest-data harnish-crest-data merged commit 8f416b1 into elastic:main Oct 9, 2023
@elasticmachine
Copy link

Package couchbase - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=couchbase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@ali786XI ali786XI ali786XI approved these changes

Assignees

@harnish-crest-data harnish-crest-data

Labels
bugfix Pull request that fixes a bug issue Integration:couchbase Couchbase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harnish-crest-data @elasticmachine @ishleenk17 @ali786XI