Skip to content

[O11y][Apache Spark] Add metric_type for executor data stream #7831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

harnish-crest-data
Copy link
Contributor

  • Enhancement

What does this PR do?

  • This PR adds metric_type mapping for the fields of the executor data stream.
  • To verify the metric_type, please refer to this file mbeans type that is used for data collection

Checklist

@harnish-crest-data harnish-crest-data marked this pull request as ready for review September 14, 2023 14:01
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner September 14, 2023 14:01
@elasticmachine
Copy link

elasticmachine commented Sep 14, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-13T06:05:28.956+0000

  • Duration: 19 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 14, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (12/16) 👍
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

…into apache_spark-executor-add-metric_type

Conflicts:
	packages/apache_spark/changelog.yml
	packages/apache_spark/manifest.yml
Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agithomas
Copy link
Contributor

@harnish-elastic , similar to #7794 there a reference to metric_type mapping?

@harnish-crest-data
Copy link
Contributor Author

harnish-crest-data commented Oct 9, 2023

@harnish-elastic , similar to #7794 there a reference to metric_type mapping?

@agithomas Since the MBean list is too large to mention in the PR description, I have already attached the link of the metric_type in the description itself

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…into apache_spark-executor-add-metric_type

Conflicts:
	packages/apache_spark/changelog.yml
	packages/apache_spark/docs/README.md
	packages/apache_spark/manifest.yml
@harnish-crest-data harnish-crest-data merged commit a840b52 into elastic:main Oct 13, 2023
@elasticmachine
Copy link

Package apache_spark - 0.7.5 containing this change is available at https://epr.elastic.co/search?package=apache_spark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants