-
Notifications
You must be signed in to change notification settings - Fork 474
[AWS] [API Gateway] Split metrics dashboard by API type and filter documents visualized #7876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] [API Gateway] Split metrics dashboard by API type and filter documents visualized #7876
Conversation
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me. Not sure if users will like the separated dashboards for different kinds of API gateway. But we can always adjust later if we get feedback.
Can we add a screenshot (not sure if multiple screenshots is allowed) into documentation please? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I believe separating the single dashboard into multiple ones per type is fair. I don't have data to back this up, but in my experience as an application developer, I usually check one API at a time;.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This better follows dashboard best practices. And, when the links panel arrives, this will be an excellent use case for it.
With the new links panel, navigation between the views is much more performant. The dashboard app itself doesn't have to reload when a link is clicked, minimizing the work it takes to show another API type.
With the links panel, filters and query are also preserved across navigation events.
…plit_apigateway_metrics_dashboard
Package aws - 2.4.0 containing this change is available at https://epr.elastic.co/search?package=aws |
@drewdaemon, what's your recommended reading list to know more about dashboard best practices? |
@zmoog unfortunately fragmentation is a problem right now. My team created a document. Some designers created a document. Someone from Security solution created a document. Looks like someone from your team tried to collect ideas into a markdown file. I agree with everything I saw in the markdown file, so you could start there. I can send you our team's document as well. But, basically, we probably need to do some unification. The specific "best practice" I was referring to is just to keep dashboards a bit smaller to improve comprehensibility and performance. Markdown panels for navigation work okay, but aren't perfect. I think the new links panel will make following this practice easier. |
Urgency
Activity Type
What does this PR do?
API Identifier
andStage
dimensions are considered. This is necessary due to additional documents being fetched based on API settings (ex. Detailed Metrics) which will result in inaccurate metrics (ex.Count
).ApiId
dimension is shared between HTTP and WebSocket)Checklist
changelog.yml
file.Author's Checklist
By Stage
- REST andApiId, Stage
- HTTP/WebSocket).How to test this PR locally
Related issues
Screenshots
REST:

HTTP:

WebSocket:

Example CloudWatch:

Example REST:
