packages/prometheus/docs: Replace `darasteam` with `datastream` #7914

limistah · 2023-09-21T09:47:38Z

What does this PR do?

The page https://docs.elastic.co/integrations/prometheus#dashboard states:

Prometheus integration is shipped including default overview dashboard. Default dashboard works only for remote_write datastream and collector darastream, if metrics are scraped from the Prometheus server metrics endpoint.

The darastream should be datastream and read like

Prometheus integration is shipped including default overview dashboard. Default dashboard works only for remote_write datastream and collector datastream, if metrics are scraped from the Prometheus server metrics endpoint.

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

Screenshots

elasticmachine · 2023-09-21T09:51:12Z

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-11-18T05:32:25.354+0000
Duration: 12 min 37 sec

Steps errors

Expand to view the steps failures

`Check integration: prometheus`

Took 0 min 1 sec . View more details here
Description: ../../build/elastic-package check -v

`Take down the Elastic stack`

Took 0 min 0 sec . View more details here
Description: build/elastic-package stack down -v

`Google Storage Download`

Took 0 min 0 sec . View more details here

`Google Storage Download`

Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

limistah · 2023-09-22T18:49:33Z

/test

limistah · 2023-10-05T20:37:20Z

The CI keeps failing, this is a typo fix. I'm not sure if I am doing anything wrong to cause the CI to fail. Can someone help?

botelastic · 2023-11-17T20:36:40Z

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

limistah · 2023-11-18T04:54:31Z

👍🏾

…s-darastream-typo-fix

limistah · 2023-11-18T05:37:13Z

Hi @tetianakravchenko

Your review is pending on this PR

Thanks

botelastic · 2023-12-18T06:03:15Z

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

limistah · 2023-12-18T08:22:49Z

👍🏾

mrodm · 2023-12-21T09:44:29Z

Hi @limistah, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

ali786XI · 2024-03-07T12:48:28Z

packages/prometheus/changelog.yml

@@ -1,4 +1,9 @@
 # newer versions go on top
+- version: "1.14.0"


Suggested change

- version: "1.14.0"

- version: "1.13.2"

As this is a minor fix in documentation bumping the patch version would suffice.

packages/prometheus/changelog.yml

botelastic · 2024-04-06T13:21:29Z

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

ishleenk17 · 2024-04-08T05:48:31Z

@limistah : Please fix the comments. We can then retrigger the build and commit the change

botelastic · 2024-05-08T06:38:11Z

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

ishleenk17 · 2024-05-08T06:48:27Z

@limistah : Lets take this PR forward!

Co-authored-by: Aliabbas Attarwala <124054599+aliabbas-elastic@users.noreply.github.com>

ali786XI · 2024-05-08T09:41:16Z

@limistah Please also bump up the manifest.yml version as well

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

limistah · 2024-05-08T10:11:47Z

@limistah Please also bump up the manifest.yml version as well

Done with this commit 70c8895

ali786XI · 2024-05-08T10:12:56Z

/test

ali786XI

LGTM

packages/prometheus/docs/README.md

ali786XI · 2024-05-08T15:24:56Z

/test

elastic-sonarqube · 2024-05-08T15:39:47Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

elasticmachine · 2024-05-08T15:39:52Z

💚 Build Succeeded

Buildkite Build
Commit: 654c71c

History

💔 Build #11258 failed 70c8895

cc @limistah

ali786XI

LGTM

elasticmachine · 2024-05-08T16:49:23Z

Package prometheus - 1.15.2 containing this change is available at https://epr.elastic.co/search?package=prometheus

typo fix

be521a8

limistah requested a review from a team as a code owner September 21, 2023 09:47

limistah requested review from tetianakravchenko and constanca-m September 21, 2023 09:47

mergify bot mentioned this pull request Sep 21, 2023

Documentation fix darasteam instead of datastream on Prometheus Integration Documentation page #7913

Closed

4 tasks

limistah added 3 commits September 21, 2023 10:58

Revert extra md

da42e10

PR Link update in change log

f5151a1

PR Link update in change log

8441ce2

constanca-m approved these changes Sep 28, 2023

View reviewed changes

limistah added 2 commits September 29, 2023 08:03

Merge branch 'main' into prometheus-darastream-typo-fix

44203de

Merge branch 'main' into prometheus-darastream-typo-fix

86a1b27

gizas approved these changes Sep 29, 2023

View reviewed changes

Merge branch 'main' into prometheus-darastream-typo-fix

a30aed6

botelastic bot added the Stalled label Nov 17, 2023

botelastic bot removed the Stalled label Nov 18, 2023

limistah and others added 3 commits November 18, 2023 05:56

Update changelog.yml

191296a

Update changelog.yml

026dad0

Merge branch 'main' of github.com:elastic/integrations into prometheu…

b8bf9eb

…s-darastream-typo-fix

botelastic bot added the Stalled label Dec 18, 2023

botelastic bot removed the Stalled label Dec 18, 2023

tetianakravchenko approved these changes Dec 18, 2023

View reviewed changes

ali786XI self-requested a review March 7, 2024 12:47

ali786XI suggested changes Mar 7, 2024

View reviewed changes

botelastic bot added Stalled and removed Stalled labels Apr 6, 2024

botelastic bot added the Stalled label May 8, 2024

botelastic bot removed the Stalled label May 8, 2024

limistah and others added 2 commits May 8, 2024 10:27

Merge branch 'main' into prometheus-darastream-typo-fix

4a6b75f

Update packages/prometheus/changelog.yml

146cadf

Co-authored-by: Aliabbas Attarwala <124054599+aliabbas-elastic@users.noreply.github.com>

limistah requested a review from ali786XI May 8, 2024 09:29

bump manifest.yml version

70c8895

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

ali786XI approved these changes May 8, 2024

View reviewed changes

ali786XI reviewed May 8, 2024

View reviewed changes

packages/prometheus/docs/README.md Outdated Show resolved Hide resolved

Fix yaml marshal error

654c71c

limistah requested a review from ali786XI May 8, 2024 15:20

ali786XI approved these changes May 8, 2024

View reviewed changes

ali786XI merged commit 96832aa into elastic:main May 8, 2024

andrewkroh added the Integration:prometheus Prometheus label Jul 22, 2024

andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 1, 2025

		@@ -1,4 +1,9 @@
		# newer versions go on top
		- version: "1.14.0"

packages/prometheus/docs: Replace darasteam with datastream #7914

packages/prometheus/docs: Replace darasteam with datastream #7914

Uh oh!

Conversation

limistah commented Sep 21, 2023

What does this PR do?

Checklist

Screenshots

Uh oh!

elasticmachine commented Sep 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Build stats

Steps errors

Check integration: prometheus

Take down the Elastic stack

Google Storage Download

Google Storage Download

🤖 GitHub comments

Uh oh!

limistah commented Sep 22, 2023

Uh oh!

limistah commented Oct 5, 2023

Uh oh!

botelastic bot commented Nov 17, 2023

Uh oh!

limistah commented Nov 18, 2023

Uh oh!

limistah commented Nov 18, 2023

Uh oh!

botelastic bot commented Dec 18, 2023

Uh oh!

limistah commented Dec 18, 2023

Uh oh!

mrodm commented Dec 21, 2023

Uh oh!

ali786XI Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

botelastic bot commented Apr 6, 2024

Uh oh!

ishleenk17 commented Apr 8, 2024

Uh oh!

botelastic bot commented May 8, 2024

Uh oh!

ishleenk17 commented May 8, 2024

Uh oh!

ali786XI commented May 8, 2024

Uh oh!

limistah commented May 8, 2024

Uh oh!

ali786XI commented May 8, 2024

Uh oh!

ali786XI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ali786XI commented May 8, 2024

Uh oh!

elastic-sonarqube bot commented May 8, 2024

Quality Gate passed

Uh oh!

elasticmachine commented May 8, 2024

💚 Build Succeeded

History

Uh oh!

ali786XI left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented May 8, 2024

Uh oh!

Uh oh!

packages/prometheus/docs: Replace `darasteam` with `datastream` #7914

packages/prometheus/docs: Replace `darasteam` with `datastream` #7914

elasticmachine commented Sep 21, 2023 •

edited

Loading

`Check integration: prometheus`

`Take down the Elastic stack`

`Google Storage Download`

`Google Storage Download`

ali786XI Mar 7, 2024 •

edited

Loading